diff --git a/src/uu/kill/src/kill.rs b/src/uu/kill/src/kill.rs index 110e8a7a6..632055b80 100644 --- a/src/uu/kill/src/kill.rs +++ b/src/uu/kill/src/kill.rs @@ -190,7 +190,8 @@ fn list(signals: &Vec) { } fn parse_signal_value(signal_name: &str) -> UResult { - let optional_signal_value = signal_by_name_or_value(signal_name); + let signal_name_upcase = signal_name.to_uppercase(); + let optional_signal_value = signal_by_name_or_value(&signal_name_upcase); match optional_signal_value { Some(x) => Ok(x), None => Err(USimpleError::new( diff --git a/tests/by-util/test_kill.rs b/tests/by-util/test_kill.rs index 73b98f218..4a6dd017b 100644 --- a/tests/by-util/test_kill.rs +++ b/tests/by-util/test_kill.rs @@ -236,6 +236,17 @@ fn test_kill_with_signal_name_new_form() { assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL)); } +#[test] +fn test_kill_with_signal_name_new_form_ignore_case() { + let mut target = Target::new(); + new_ucmd!() + .arg("-s") + .arg("KiLl") + .arg(format!("{}", target.pid())) + .succeeds(); + assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL)); +} + #[test] fn test_kill_with_signal_prefixed_name_new_form() { let mut target = Target::new(); @@ -247,6 +258,29 @@ fn test_kill_with_signal_prefixed_name_new_form() { assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL)); } +#[test] +fn test_kill_with_signal_prefixed_name_new_form_ignore_case() { + let mut target = Target::new(); + new_ucmd!() + .arg("-s") + .arg("SiGKiLl") + .arg(format!("{}", target.pid())) + .succeeds(); + assert_eq!(target.wait_for_signal(), Some(libc::SIGKILL)); +} + +#[test] +fn test_kill_with_signal_name_new_form_unknown_must_match_input_case() { + let target = Target::new(); + new_ucmd!() + .arg("-s") + .arg("IaMnOtAsIgNaL") // spell-checker:disable-line + .arg(format!("{}", target.pid())) + .fails() + .stderr_contains("unknown signal") + .stderr_contains("IaMnOtAsIgNaL"); // spell-checker:disable-line +} + #[test] fn test_kill_no_pid_provided() { // spell-checker:disable-line