From c08674da28a567dd77e64385eaf56d7607757d4d Mon Sep 17 00:00:00 2001 From: Roy Ivy III Date: Tue, 7 Apr 2020 21:55:04 -0500 Subject: [PATCH] fix build failure caused by data-encoding v2.2.0 - hold data-encoding to known working "<= 2.1.2" .# [why] data-encoding v2.2.0 causes a build error for '1.31.0-i686-pc-windows-msvc'. ``` cargo +1.31.0-i686-pc-windows-msvc build --target=i686-pc-windows-msvc --all-features ... error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130) --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\data-encoding-2.2.0\src\lib.rs:194:5 | 187 | / mod prelude { 188 | | pub use std::borrow::Cow; 189 | | } | |_- not an extern crate passed with `--extern` ... 194 | use prelude::*; | ^^^^^^^ | ... ``` --- src/uucore/Cargo.toml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/uucore/Cargo.toml b/src/uucore/Cargo.toml index 0fcf2021a..2148eb2d4 100644 --- a/src/uucore/Cargo.toml +++ b/src/uucore/Cargo.toml @@ -21,14 +21,16 @@ getopts = "<= 0.2.21" failure = { version = "<= 0.1.1", optional = true } failure_derive = { version = "<= 0.1.1", optional = true } time = { version = "<= 0.1.42", optional = true } -data-encoding = { version = "^2.1", optional = true } libc = { version = "<= 0.2.66", optional = true } wild = "2.0.1" nix = { version = "<= 0.13", optional = true } lazy_static = { version = "1.3", optional = true } platform-info = { version = "<= 0.0.1", optional = true } +## problem dependencies # * transitive dependency via 'failure'; pin to <= v0.3.30 to avoid increasing MinSRV to v1.33.0 backtrace = ">= 0.3.3, <= 0.3.30" +# * data-encoding: require 2.1, but 2.2.0 breaks the build for MinSRV 1.31.0 +data-encoding = { version = "~2.1", optional = true } [target.'cfg(target_os = "redox")'.dependencies] termion = "1.5"