RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00
Code Issues Activity

stat: improve GNU compatibility (#6933)

Browse source 
* stat: fix the quotes when dealing with %N

and other formats
should fix
tests/stat/stat-fmt.sh

* stats: use an enum instead of a string

* stats: split the functions into smaller functions

* stat: handle byte as a format for better display

* stat: handle error better. should make tests/stat/stat-printf.pl pass

* stat: Some escape sequences are non-standard

* Fix tests

* Take comments into account
This commit is contained in:
Sylvestre Ledru 2024-12-10 08:48:52 +01:00 • committed by GitHub
parent 22f3358d47
commit c60203ddd3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 440 additions and 231 deletions
Download patch file Download diff file Expand all files Collapse all files

100
tests/by-util/test_stat.rs
View file

@ -242,7 +242,7 @@ fn test_multi_files() {
#[test]
fn test_printf() {
let args = [
"--printf=123%-# 15q\\r\\\"\\\\\\a\\b\\e\\f\\v%+020.23m\\x12\\167\\132\\112\\n",
"--printf=123%-# 15q\\r\\\"\\\\\\a\\b\\x1B\\f\\x0B%+020.23m\\x12\\167\\132\\112\\n",
"/",
];
let ts = TestScenario::new(util_name!());
@ -256,11 +256,10 @@ fn test_pipe_fifo() {
let (at, mut ucmd) = at_and_ucmd!();
at.mkfifo("FIFO");
ucmd.arg("FIFO")
.run()
.succeeds()
.no_stderr()
.stdout_contains("fifo")
.stdout_contains("File: FIFO")
.succeeded();
.stdout_contains("File: FIFO");
}
#[test]
@ -275,19 +274,17 @@ fn test_stdin_pipe_fifo1() {
new_ucmd!()
.arg("-")
.set_stdin(std::process::Stdio::piped())
.run()
.succeeds()
.no_stderr()
.stdout_contains("fifo")
.stdout_contains("File: -")
.succeeded();
.stdout_contains("File: -");
new_ucmd!()
.args(&["-L", "-"])
.set_stdin(std::process::Stdio::piped())
.run()
.succeeds()
.no_stderr()
.stdout_contains("fifo")
.stdout_contains("File: -")
.succeeded();
.stdout_contains("File: -");
}
#[test]
@ -299,11 +296,10 @@ fn test_stdin_pipe_fifo2() {
new_ucmd!()
.arg("-")
.set_stdin(std::process::Stdio::null())
.run()
.succeeds()
.no_stderr()
.stdout_contains("character special file")
.stdout_contains("File: -")
.succeeded();
.stdout_contains("File: -");
}
#[test]
@ -339,11 +335,10 @@ fn test_stdin_redirect() {
ts.ucmd()
.arg("-")
.set_stdin(std::fs::File::open(at.plus("f")).unwrap())
.run()
.succeeds()
.no_stderr()
.stdout_contains("regular empty file")
.stdout_contains("File: -")
.succeeded();
.stdout_contains("File: -");
}
#[test]
@ -352,3 +347,76 @@ fn test_without_argument() {
.fails()
.stderr_contains("missing operand\nTry 'stat --help' for more information.");
}
#[test]
fn test_quoting_style_locale() {
let ts = TestScenario::new(util_name!());
let at = &ts.fixtures;
at.touch("'");
ts.ucmd()
.env("QUOTING_STYLE", "locale")
.args(&["-c", "%N", "'"])
.succeeds()
.stdout_only("'\\''\n");
ts.ucmd()
.args(&["-c", "%N", "'"])
.succeeds()
.stdout_only("\"'\"\n");
}
#[test]
fn test_printf_octal_1() {
let ts = TestScenario::new(util_name!());
let expected_stdout = vec![0x0A, 0xFF]; // Newline + byte 255
ts.ucmd()
.args(&["--printf=\\012\\377", "."])
.succeeds()
.stdout_is_bytes(expected_stdout);
}
#[test]
fn test_printf_octal_2() {
let ts = TestScenario::new(util_name!());
let expected_stdout = vec![b'.', 0x0A, b'a', 0xFF, b'b'];
ts.ucmd()
.args(&["--printf=.\\012a\\377b", "."])
.succeeds()
.stdout_is_bytes(expected_stdout);
}
#[test]
fn test_printf_incomplete_hex() {
let ts = TestScenario::new(util_name!());
ts.ucmd()
.args(&["--printf=\\x", "."])
.succeeds()
.stderr_contains("warning: incomplete hex escape");
}
#[test]
fn test_printf_bel_etc() {
let ts = TestScenario::new(util_name!());
let expected_stdout = vec![0x07, 0x08, 0x0C, 0x0A, 0x0D, 0x09]; // BEL, BS, FF, LF, CR, TAB
ts.ucmd()
.args(&["--printf=\\a\\b\\f\\n\\r\\t", "."])
.succeeds()
.stdout_is_bytes(expected_stdout);
}
#[test]
fn test_printf_invalid_directive() {
let ts = TestScenario::new(util_name!());
ts.ucmd()
.args(&["--printf=%9", "."])
.fails()
.code_is(1)
.stderr_contains("'%9': invalid directive");
ts.ucmd()
.args(&["--printf=%9%", "."])
.fails()
.code_is(1)
.stderr_contains("'%9%': invalid directive");
}