RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-27 11:07:44 +00:00
Code Issues Activity

Merge pull request #5757 from cakebaker/cp_show_same_file_error

Browse source 
cp: show error if source and destination are same file
This commit is contained in:
Sylvestre Ledru 2023-12-31 17:05:30 +01:00 • committed by GitHub
commit cbf42189a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/uu/cp/src/cp.rs
View file

@ -1713,6 +1713,7 @@ fn copy_file(
if are_hardlinks_to_same_file(source, dest) if are_hardlinks_to_same_file(source, dest)
&& !options.force() && !options.force()
&& options.backup == BackupMode::NoBackup && options.backup == BackupMode::NoBackup
&& source != dest
{ {
return Ok(()); return Ok(());
} }

14
tests/by-util/test_cp.rs
View file

@ -117,6 +117,20 @@ fn test_cp_duplicate_files() {
assert_eq!(at.read(TEST_COPY_TO_FOLDER_FILE), "Hello, World!\n"); assert_eq!(at.read(TEST_COPY_TO_FOLDER_FILE), "Hello, World!\n");
} }
#[test]
fn test_cp_same_file() {
let (at, mut ucmd) = at_and_ucmd!();
let file = "a";
at.touch(file);
ucmd.arg(file)
.arg(file)
.fails()
.code_is(1)
.stderr_contains(format!("'{file}' and '{file}' are the same file"));
}
#[test] #[test]
fn test_cp_multiple_files_target_is_file() { fn test_cp_multiple_files_target_is_file() {
new_ucmd!() new_ucmd!()