RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00
Code Issues Activity

dd: error if iflag=directory and input is stdin

Browse source 
Make `dd` error if `iflag=directory` and the input file is not a
directory, as in

    : | dd iflag=directory

Fixes #5900
This commit is contained in:
Jeffrey Finkelstein 2025-01-10 23:28:02 -05:00 • committed by Sylvestre Ledru
parent 54bc3cf944
commit d9b3b3ef67
2 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/uu/dd/src/dd.rs
View file

@ -54,7 +54,7 @@ use nix::{
};
use uucore::display::Quotable;
#[cfg(unix)]
use uucore::error::set_exit_code;
use uucore::error::{set_exit_code, USimpleError};
use uucore::error::{FromIo, UResult};
#[cfg(target_os = "linux")]
use uucore::show_if_err;
@ -338,11 +338,11 @@ impl<'a> Input<'a> {
let mut src = Source::stdin_as_file();
#[cfg(unix)]
if let Source::StdinFile(f) = &src {
// GNU compatibility:
// this will check whether stdin points to a folder or not
if f.metadata()?.is_file() && settings.iflags.directory {
show_error!("standard input: not a directory");
return Err(1.into());
if settings.iflags.directory && !f.metadata()?.is_dir() {
return Err(USimpleError::new(
1,
"setting flags for 'standard input': Not a directory",
));
}
};
if settings.skip > 0 {

21
tests/by-util/test_dd.rs
View file

@ -1728,7 +1728,26 @@ fn test_iflag_directory_fails_when_file_is_passed_via_std_in() {
.args(&["iflag=directory", "count=0"])
.set_stdin(std::process::Stdio::from(File::open(filename).unwrap()))
.fails()
.stderr_contains("standard input: not a directory");
.stderr_only("dd: setting flags for 'standard input': Not a directory\n");
}
#[test]
#[cfg(any(target_os = "linux", target_os = "android"))]
fn test_iflag_directory_passes_when_dir_is_redirected() {
new_ucmd!()
.args(&["iflag=directory", "count=0"])
.set_stdin(std::process::Stdio::from(File::open(".").unwrap()))
.succeeds();
}
#[test]
#[cfg(any(target_os = "linux", target_os = "android"))]
fn test_iflag_directory_fails_when_file_is_piped_via_std_in() {
new_ucmd!()
.arg("iflag=directory")
.pipe_in("")
.fails()
.stderr_only("dd: setting flags for 'standard input': Not a directory\n");
}
#[test]