From dfc1c8a2dd031b20830a0baf076780aef6391d0c Mon Sep 17 00:00:00 2001 From: Jeffrey Finkelstein Date: Mon, 30 May 2022 09:30:47 -0400 Subject: [PATCH] mktemp: exit with status 1 on usage errors --- src/uu/mktemp/src/mktemp.rs | 2 +- tests/by-util/test_mktemp.rs | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/uu/mktemp/src/mktemp.rs b/src/uu/mktemp/src/mktemp.rs index e145a3933..7236a7f69 100644 --- a/src/uu/mktemp/src/mktemp.rs +++ b/src/uu/mktemp/src/mktemp.rs @@ -91,7 +91,7 @@ impl Display for MkTempError { #[uucore::main] pub fn uumain(args: impl uucore::Args) -> UResult<()> { - let matches = uu_app().get_matches_from(args); + let matches = uu_app().try_get_matches_from(args)?; let template = matches.value_of(ARG_TEMPLATE).unwrap(); let tmpdir = matches.value_of(OPT_TMPDIR).unwrap_or_default(); diff --git a/tests/by-util/test_mktemp.rs b/tests/by-util/test_mktemp.rs index 86c4ba4db..d7897b04c 100644 --- a/tests/by-util/test_mktemp.rs +++ b/tests/by-util/test_mktemp.rs @@ -558,3 +558,8 @@ fn test_too_few_xs_suffix_directory() { .fails() .stderr_only("mktemp: too few X's in template 'aXXX'\n"); } + +#[test] +fn test_too_many_arguments() { + new_ucmd!().args(&["-q", "a", "b"]).fails().code_is(1); +}