RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-27 19:17:43 +00:00
Code Issues Activity

cut: fix off-by-one error for range calculation

Browse source 
When determining the range from which to select portions of a line, the
upper limit of the range is a usize. The maximum upper value is
usize::MAX, but at one point this value is incremented, causing an
overflow. By setting the maximum upper value to usize::MAX-1, the bug is
averted. Since the upper limit of the range is an index (thus, ranging
from 0 to 2^64-1 for 64-bit platforms), the maximum usize should not be
reached.
This commit is contained in:
Joseph Crail 2015-11-28 00:42:35 -05:00
parent bdf891c630
commit e3eb633ac9
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cut/ranges.rs
View file

@ -37,7 +37,7 @@ impl FromStr for Range {
}
(Some(n), Some(m)) if m.len() == 0 => {
if let Ok(low) = n.parse::<usize>() {
if low > 0 { Ok(Range{ low: low, high: MAX}) } else { Err(field) }
if low > 0 { Ok(Range{ low: low, high: MAX - 1}) } else { Err(field) }
} else {
Err(inval)
}
@ -118,10 +118,10 @@ pub fn complement(ranges: &Vec<Range>) -> Vec<Range> {
}
}
(Some(last), None) => {
if last.high < usize::MAX {
if last.high < usize::MAX - 1 {
complements.push(Range {
low: last.high + 1,
high: usize::MAX
high: usize::MAX - 1
});
}
}