From 8478570c042c0f9b4a82e88e9b669e60bca346c0 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Tue, 4 Oct 2022 10:14:43 +0200 Subject: [PATCH 1/3] Disable test_when_piped_input_then_no_broken_pipe by default It is blocking the executions of the tests and I suspect it is breaking android --- tests/common/util.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/common/util.rs b/tests/common/util.rs index 2597af2c1..932ae1c31 100644 --- a/tests/common/util.rs +++ b/tests/common/util.rs @@ -1843,6 +1843,7 @@ mod tests { // should fail with any command that takes piped input. // See also https://github.com/uutils/coreutils/issues/3895 #[test] + #[cfg_attr(not(feature = "expensive_tests"), ignore)] fn test_when_piped_input_then_no_broken_pipe() { let ts = TestScenario::new("tail"); for i in 0..10000 { From 3cda177d3449162601e77db847fac6b5e3864f9b Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Tue, 4 Oct 2022 14:41:26 +0200 Subject: [PATCH 2/3] Disable test_preference_of_userspec on android --- tests/by-util/test_chroot.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/by-util/test_chroot.rs b/tests/by-util/test_chroot.rs index c814b5815..ca04fd984 100644 --- a/tests/by-util/test_chroot.rs +++ b/tests/by-util/test_chroot.rs @@ -59,6 +59,7 @@ fn test_invalid_user_spec() { } #[test] +#[cfg(not(target_os = "android"))] fn test_preference_of_userspec() { let scene = TestScenario::new(util_name!()); let result = scene.cmd("whoami").run(); From 858b2a5b9910368e9e00c6b6e5c027bdafbce3a3 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Tue, 4 Oct 2022 17:24:06 +0200 Subject: [PATCH 3/3] disable the new tests --- tests/by-util/test_test.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/by-util/test_test.rs b/tests/by-util/test_test.rs index 54ee03985..9a5186302 100644 --- a/tests/by-util/test_test.rs +++ b/tests/by-util/test_test.rs @@ -341,7 +341,7 @@ fn test_file_is_itself() { } #[test] -#[cfg(not(target_env = "musl"))] +#[cfg(not(any(target_env = "musl", target_os = "android")))] fn test_file_is_newer_than_and_older_than_itself() { // odd but matches GNU new_ucmd!() @@ -388,7 +388,7 @@ fn test_same_device_inode() { } #[test] -#[cfg(not(target_env = "musl"))] +#[cfg(not(any(target_env = "musl", target_os = "android")))] // musl: creation time is not available on this platform currently fn test_newer_file() { let scenario = TestScenario::new(util_name!());