diff --git a/.github/workflows/GnuComment.yml b/.github/workflows/GnuComment.yml index fd73520e6..f74c022ed 100644 --- a/.github/workflows/GnuComment.yml +++ b/.github/workflows/GnuComment.yml @@ -1,7 +1,5 @@ -name: Comment on GNU test results on the PR +name: GnuComment -# read-write repo token -# access to secrets on: workflow_run: workflows: ["GnuTests"] @@ -9,35 +7,34 @@ on: - completed jobs: - upload: + post-comment: runs-on: ubuntu-latest if: > - github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' + github.event.workflow_run.event == 'pull_request' steps: - name: 'Download artifact' uses: actions/github-script@v3.1.0 with: script: | - # List all artifacts from GnuTests + // List all artifacts from GnuTests var artifacts = await github.actions.listWorkflowRunArtifacts({ - owner: context.repo.owner, - repo: context.repo.repo, - run_id: ${{github.event.workflow_run.id }}, + owner: context.repo.owner, + repo: context.repo.repo, + run_id: ${{ github.event.workflow_run.id }}, }); - # Download the "comment" artifact, which contains a PR number (NR) and result.txt + // Download the "comment" artifact, which contains a PR number (NR) and result.txt var matchArtifact = artifacts.data.artifacts.filter((artifact) => { return artifact.name == "comment" })[0]; var download = await github.actions.downloadArtifact({ - owner: context.repo.owner, - repo: context.repo.repo, - artifact_id: matchArtifact.id, - archive_format: 'zip', + owner: context.repo.owner, + repo: context.repo.repo, + artifact_id: matchArtifact.id, + archive_format: 'zip', }); var fs = require('fs'); - fs.writeFileSync('${{github.workspace}}/comment.zip', Buffer.from(download.data)); + fs.writeFileSync('${{ github.workspace }}/comment.zip', Buffer.from(download.data)); - run: unzip comment.zip - name: 'Comment on PR' diff --git a/.github/workflows/GnuTests.yml b/.github/workflows/GnuTests.yml index 4db4220c9..086174654 100644 --- a/.github/workflows/GnuTests.yml +++ b/.github/workflows/GnuTests.yml @@ -244,6 +244,7 @@ jobs: fi if test -n "${have_new_failures}" ; then exit -1 ; fi - name: Upload comparison log (for GnuComment workflow) + if: success() || failure() # run regardless of prior step success/failure uses: actions/upload-artifact@v3 with: name: comment