RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-07-28 03:27:44 +00:00
Code Issues Activity

uniq: fix flaky test gnu_tests

Browse source 
The testcase tries to write to the stdin pipe while the process under
test is simultaneously exiting with an error code. Naturally, this is a
race, and we should ignore any stdin write errors. However, adding this
feature to the list makes it even more unreadable, and adds no real
value, so let's skip the input data entirely.
This commit is contained in:
Ben Wiederhake 2024-02-25 17:56:04 +01:00
parent d7a09c042a
commit e91d0bd14f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/by-util/test_uniq.rs
View file

@ -755,7 +755,7 @@ fn gnu_tests() {
TestCase { TestCase {
name: "112", name: "112",
args: &["-D", "-c"], args: &["-D", "-c"],
input: "a a\na b\n", input: "", // Note: Different from GNU test, but should not matter
stdout: Some(""), stdout: Some(""),
stderr: Some("uniq: printing all duplicated lines and repeat counts is meaningless\nTry 'uniq --help' for more information.\n"), stderr: Some("uniq: printing all duplicated lines and repeat counts is meaningless\nTry 'uniq --help' for more information.\n"),
exit: Some(1), exit: Some(1),
@ -811,7 +811,7 @@ fn gnu_tests() {
TestCase { TestCase {
name: "119", name: "119",
args: &["--all-repeated=badoption"], args: &["--all-repeated=badoption"],
input: "a a\na b\n", input: "", // Note: Different from GNU test, but should not matter
stdout: Some(""), stdout: Some(""),
stderr: Some("uniq: invalid argument 'badoption' for '--all-repeated'\nValid arguments are:\n - 'none'\n - 'prepend'\n - 'separate'\nTry 'uniq --help' for more information.\n"), stderr: Some("uniq: invalid argument 'badoption' for '--all-repeated'\nValid arguments are:\n - 'none'\n - 'prepend'\n - 'separate'\nTry 'uniq --help' for more information.\n"),
exit: Some(1), exit: Some(1),