From ea8ed8d5da5712ea09b0975a46b8eaae0c753eee Mon Sep 17 00:00:00 2001
From: Roy Ivy III <rivy.dev@gmail.com>
Date: Thu, 26 Dec 2019 15:22:08 -0600
Subject: [PATCH] refactor/polish ~ fix `cargo clippy` complaints (&Vec => &[])

---
 src/numfmt/numfmt.rs                                   |  2 +-
 src/od/parse_formats.rs                                |  2 +-
 .../tokenize/num_format/formatters/base_conv/mod.rs    | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/numfmt/numfmt.rs b/src/numfmt/numfmt.rs
index a8174438f..8b2c09343 100644
--- a/src/numfmt/numfmt.rs
+++ b/src/numfmt/numfmt.rs
@@ -257,7 +257,7 @@ fn parse_options(args: &Matches) -> Result<NumfmtOptions> {
     })
 }
 
-fn handle_args(args: &Vec<String>, options: NumfmtOptions) -> Result<()> {
+fn handle_args(args: &[String], options: NumfmtOptions) -> Result<()> {
     for l in args {
         println!("{}", format_string(l.clone(), &options)?)
     }
diff --git a/src/od/parse_formats.rs b/src/od/parse_formats.rs
index 76f472414..2a03baa7a 100644
--- a/src/od/parse_formats.rs
+++ b/src/od/parse_formats.rs
@@ -100,7 +100,7 @@ fn od_argument_with_option(ch: char) -> bool {
 /// arguments with parameters like -w16 can only appear at the end: -fvoxw16
 /// parameters of -t/--format specify 1 or more formats.
 /// if -- appears on the commandline, parsing should stop.
-pub fn parse_format_flags(args: &Vec<String>) -> Result<Vec<ParsedFormatterItemInfo>, String> {
+pub fn parse_format_flags(args: &[String]) -> Result<Vec<ParsedFormatterItemInfo>, String> {
     let mut formats = Vec::new();
 
     // args[0] is the name of the binary
diff --git a/src/printf/tokenize/num_format/formatters/base_conv/mod.rs b/src/printf/tokenize/num_format/formatters/base_conv/mod.rs
index af18044f9..2aaa5acbd 100644
--- a/src/printf/tokenize/num_format/formatters/base_conv/mod.rs
+++ b/src/printf/tokenize/num_format/formatters/base_conv/mod.rs
@@ -1,4 +1,4 @@
-pub fn arrnum_int_mult(arr_num: &Vec<u8>, basenum: u8, base_ten_int_fact: u8) -> Vec<u8> {
+pub fn arrnum_int_mult(arr_num: &[u8], basenum: u8, base_ten_int_fact: u8) -> Vec<u8> {
     let mut carry: u16 = 0;
     let mut rem: u16;
     let mut new_amount: u16;
@@ -164,8 +164,8 @@ pub fn arrnum_int_div_step<'a>(
 // ArrFloatDivOut { quotient: quotient, remainder: remainder }
 // }
 //
-pub fn arrnum_int_add(arrnum: &Vec<u8>, basenum: u8, base_ten_int_term: u8) -> Vec<u8> {
-    let mut carry: u16 = base_ten_int_term as u16;
+pub fn arrnum_int_add(arrnum: &[u8], basenum: u8, base_ten_int_term: u8) -> Vec<u8> {
+    let mut carry: u16 = u16::from(base_ten_int_term);
     let mut rem: u16;
     let mut new_amount: u16;
     let base: u16 = basenum as u16;
@@ -218,7 +218,7 @@ pub fn unsigned_to_arrnum(src: u16) -> Vec<u8> {
 
 // temporary needs-improvement-function
 #[allow(unused_variables)]
-pub fn base_conv_float(src: &Vec<u8>, radix_src: u8, radix_dest: u8) -> f64 {
+pub fn base_conv_float(src: &[u8], radix_src: u8, radix_dest: u8) -> f64 {
     // it would require a lot of addl code
     // to implement this for arbitrary string input.
     // until then, the below operates as an outline
@@ -253,7 +253,7 @@ pub fn str_to_arrnum(src: &str, radix_def_src: &dyn RadixDef) -> Vec<u8> {
     intermed_in
 }
 
-pub fn arrnum_to_str(src: &Vec<u8>, radix_def_dest: &dyn RadixDef) -> String {
+pub fn arrnum_to_str(src: &[u8], radix_def_dest: &dyn RadixDef) -> String {
     let mut str_out = String::new();
     for u in src.iter() {
         match radix_def_dest.from_u8(u.clone()) {