From ed69d797b526bf4a01f676d591a688664cb1b281 Mon Sep 17 00:00:00 2001
From: Michael Debertol <michael.debertol@gmail.com>
Date: Wed, 2 Jun 2021 21:02:12 +0200
Subject: [PATCH] ln: reject --relative without --symbolic

---
 src/uu/ln/src/ln.rs      |  3 ++-
 tests/by-util/test_ln.rs | 19 +++++--------------
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/uu/ln/src/ln.rs b/src/uu/ln/src/ln.rs
index 0c60405f6..4bd3310cc 100644
--- a/src/uu/ln/src/ln.rs
+++ b/src/uu/ln/src/ln.rs
@@ -184,7 +184,8 @@ pub fn uumain(args: impl uucore::Args) -> i32 {
             Arg::with_name(OPT_RELATIVE)
                 .short("r")
                 .long(OPT_RELATIVE)
-                .help("create symbolic links relative to link location"),
+                .help("create symbolic links relative to link location")
+                .requires(OPT_SYMBOLIC),
         )
         .arg(
             Arg::with_name(OPT_VERBOSE)
diff --git a/tests/by-util/test_ln.rs b/tests/by-util/test_ln.rs
index e475e3608..00ea85ecd 100644
--- a/tests/by-util/test_ln.rs
+++ b/tests/by-util/test_ln.rs
@@ -428,20 +428,6 @@ fn test_symlink_relative() {
     assert_eq!(at.resolve_link(link), file_a);
 }
 
-#[test]
-fn test_hardlink_relative() {
-    let (at, mut ucmd) = at_and_ucmd!();
-    let file_a = "test_hardlink_relative_a";
-    let link = "test_hardlink_relative_link";
-
-    at.touch(file_a);
-
-    // relative hardlink
-    ucmd.args(&["-r", "-v", file_a, link])
-        .succeeds()
-        .stdout_only(format!("'{}' -> '{}'\n", link, file_a));
-}
-
 #[test]
 fn test_symlink_relative_path() {
     let (at, mut ucmd) = at_and_ucmd!();
@@ -571,3 +557,8 @@ fn test_symlink_no_deref_file() {
     assert!(at.is_symlink(link));
     assert_eq!(at.resolve_link(link), file1);
 }
+
+#[test]
+fn test_relative_requires_symbolic() {
+    new_ucmd!().args(&["-r", "foo", "bar"]).fails();
+}