Based on testing with GNU's pwd, it seems like the -P flag should
take precedence over the use of the POSIXLY_CORRECT flag.
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
prevents --preserve to eat the next argument when no value is passed.
default value for --preserve is set to mode,ownership(unix only),timestamps
before the patch:
cp --preserve foo bar
error: invalid value 'foo' for '--preserve [<ATTR_LIST>...]'
[possible values: mode, ownership, timestamps, context, link, links, xattr, all]
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
This no longer triggers the `invalid_from_utf8_unchecked` lint. It
is also a bit cleaner and no longer requires `unsafe` because
OsString is not guaranteed to be valid UTF-8.
uniq ought to be able to work with files whose names are not UTF-8.
I've also taken the chance to remove some unnecessary String
allocations.
Additionally, both open_input_file and open_output_file were returning
items with two implie levels of `Box<dyn ...>` that were not necessary.
In the case of stdin as input, it was not necessary to wrap stdin with a
BufReader, StdinLock implements BufRead itself.
* Display a message when the owner is not changed.
* Display a message when the current user/group doesn't match those specified in the `--from` args.
* print messages to stdout
* Show the message "ownership of 'foo' retained as 'bar'" for every path entry when `chown -v -R --from=`
* fix chown tests: test stdout and not stderr
* factorize duplicate code in a function
* Display a message when the owner is not changed.
* Display a message when the current user/group doesn't match those specified in the `--from` args.
* print messages to stdout
* Show the message "ownership of 'foo' retained as 'bar'" for every path entry when `chown -v -R --from=`
* fix chown tests: test stdout and not stderr
* factorize duplicate code in a function
* display the retained ownership details according to the destination ownership.
My previous commits meant to bring our wc's output and behavior in line
with GNU's. There should be tests that check for these changes!
I found a stupid bug in my own changes, I was not adding 1 to the
indexes produced by .enumerate() when printing errors.
