From 12b31b3def4d56a5213d10e28868d19f15227283 Mon Sep 17 00:00:00 2001
From: tcude <tacude1@buffs.wtamu.edu>
Date: Mon, 5 Feb 2024 17:57:24 -0600
Subject: [PATCH] added function to create EFI disk for newly migrated VM

---
 vmware_to_proxmox.sh | 46 ++++++++++++++++++++++++++++++++------------
 1 file changed, 34 insertions(+), 12 deletions(-)

diff --git a/vmware_to_proxmox.sh b/vmware_to_proxmox.sh
index 3218734..309aff1 100755
--- a/vmware_to_proxmox.sh
+++ b/vmware_to_proxmox.sh
@@ -69,66 +69,88 @@ function create_proxmox_vm() {
         echo "Error: Invalid VM ID '$VM_ID'. Please enter a numeric value."
         exit 1
     fi
-    # Check if a VM with the given ID already exists
+    # Check for VM that already exists with provided VM ID
     if ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qm status $VM_ID" &> /dev/null; then
         echo "Error: VM with ID '$VM_ID' already exists. Please enter a different ID."
         exit 1
     fi
 
-    # Extract OVF from OVA
     echo "Extracting OVF from OVA..."
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "tar -xvf /var/vm-migration/$VM_NAME.ova -C /var/vm-migration/"
 
-    # Find the OVF file
     local ovf_file=$(ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "find /var/vm-migration -name '*.ovf'")
     echo "Found OVF file: $ovf_file"
 
-    # Find the VMDK file
     echo "Finding .vmdk file..."
     local vmdk_file=$(ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "find /var/vm-migration -name '$VM_NAME-disk*.vmdk'")
     echo "Found .vmdk file: $vmdk_file"
 
-    # Ensure that only one .vmdk file is found
+    # Check for ensuring only one .vmdk file is found
     if [[ $(echo "$vmdk_file" | wc -l) -ne 1 ]]; then
        echo "Error: Multiple or no .vmdk files found."
        exit 1
     fi
 
-    # Convert the VMDK file to raw format
+    # Convert .vmdk file to raw format
     local raw_file="$VM_NAME.raw"
     local raw_path="/var/tmp/$raw_file"
     echo "Converting .vmdk file to raw format..."
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qemu-img convert -f vmdk -O raw '$vmdk_file' '$raw_path'"
 
-    # Create the VM with UEFI BIOS, VLAN tag, and specify the SCSI hardware
+    # Create the VM
     echo "Creating VM in Proxmox with UEFI, VLAN tag, and SCSI hardware..."
     echo "VM ID is: $VM_ID"
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qm create $VM_ID --name $VM_NAME --memory 2048 --cores 2 --net0 virtio,bridge=vmbr69,tag=$VLAN_TAG --bios ovmf --scsihw virtio-scsi-pci"
-    
-    # Import the disk to local-lvm storage
+
+    # Import disk to local-lvm storage
     echo "Importing disk to local-lvm storage..."
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qm importdisk $VM_ID $raw_path local-lvm"
 
-    # Attach the disk to the VM and set it as the first boot device
+    # Attach disk to VM and set it as first boot device
     local disk_name="vm-$VM_ID-disk-0"
     echo "Attaching disk to VM and setting it as the first boot device..."
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qm set $VM_ID --scsi0 local-lvm:$disk_name --boot c --bootdisk scsi0"
+
 }
 
-# Clear out temp files from /var/vm-migrations
+# Clean up files from /var/vm-migrations on proxmox host
 function cleanup_migration_directory() {
     echo "Cleaning up /var/vm-migration directory..."
     ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "rm -rf /var/vm-migration/*"
 }
 
+# Clean up .ova files from local
 function cleanup_local_ova_files() {
     echo "Removing local .ova files..."
     rm -f "$VM_NAME.ova"
 }
 
+# Add an EFI disk to the VM
+function add_efi_disk_to_vm() {
+    echo "Adding EFI disk to the VM..."
+    local vg_name="pve" #LVM volume group name - should be this by default
+    local efi_disk_size="4M"
+    local efi_disk="vm-$VM_ID-disk-1"
+    
+    # Create EFI disk as a LV
+    echo "Creating EFI disk as a logical volume..."
+    ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "lvcreate -L $efi_disk_size -n $efi_disk $vg_name" || {
+        echo "Failed to create EFI disk logical volume."
+        exit 1
+    }
+
+    # Attach EFI disk to VM
+    echo "Attaching EFI disk to VM..."
+    ssh $PROXMOX_USERNAME@$PROXMOX_SERVER "qm set $VM_ID --efidisk0 local-lvm:$efi_disk,size=$efi_disk_size,efitype=4m,pre-enrolled-keys=1" || {
+        echo "Failed to add EFI disk to VM."
+        exit 1
+    }
+}
+
 # Main process
 export_vmware_vm
 transfer_vm
 create_proxmox_vm
 cleanup_migration_directory
-cleanup_local_ova_files
\ No newline at end of file
+cleanup_local_ova_files
+add_efi_disk_to_vm
\ No newline at end of file