RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:47:45 +00:00
Code Issues Activity Actions

Ladybird: Remove some awkward camelCase signal names

Browse source 
We use snake_case for everything except when we're forced by Qt to use
their camelCase names.
This commit is contained in:
Andreas Kling 2022-09-12 09:04:51 +02:00 • committed by Andrew Kaster
parent 0c4ae810d7
commit 031005de2d
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Ladybird/Tab.cpp
View file

@ -59,16 +59,16 @@ Tab::Tab(QMainWindow* window)
m_toolbar->addAction(m_home_action); m_toolbar->addAction(m_home_action);
m_toolbar->addWidget(m_location_edit); m_toolbar->addWidget(m_location_edit);
QObject::connect(m_view, &WebView::linkHovered, [this](QString const& title) { QObject::connect(m_view, &WebView::link_hovered, [this](QString const& title) {
m_hover_label->setText(title); m_hover_label->setText(title);
update_hover_label(); update_hover_label();
m_hover_label->show(); m_hover_label->show();
}); });
QObject::connect(m_view, &WebView::linkUnhovered, [this] { QObject::connect(m_view, &WebView::link_unhovered, [this] {
m_hover_label->hide(); m_hover_label->hide();
}); });
QObject::connect(m_view, &WebView::loadStarted, [this](const URL& url) { QObject::connect(m_view, &WebView::load_started, [this](const URL& url) {
m_location_edit->setText(url.to_string().characters()); m_location_edit->setText(url.to_string().characters());
m_history.push(url, m_title.toUtf8().data()); m_history.push(url, m_title.toUtf8().data());
}); });

6
Ladybird/WebView.cpp
View file

@ -173,7 +173,7 @@ public:
virtual void page_did_start_loading(AK::URL const& url) override virtual void page_did_start_loading(AK::URL const& url) override
{ {
emit m_view.loadStarted(url); emit m_view.load_started(url);
} }
virtual void page_did_finish_loading(AK::URL const&) override virtual void page_did_finish_loading(AK::URL const&) override
@ -252,12 +252,12 @@ public:
virtual void page_did_hover_link(AK::URL const& url) override virtual void page_did_hover_link(AK::URL const& url) override
{ {
emit m_view.linkHovered(url.to_string().characters()); emit m_view.link_hovered(url.to_string().characters());
} }
virtual void page_did_unhover_link() override virtual void page_did_unhover_link() override
{ {
emit m_view.linkUnhovered(); emit m_view.link_unhovered();
} }
virtual void page_did_invalidate(Gfx::IntRect const&) override virtual void page_did_invalidate(Gfx::IntRect const&) override

6
Ladybird/WebView.h
View file

@ -50,9 +50,9 @@ public:
Gfx::IntPoint to_widget(Gfx::IntPoint) const; Gfx::IntPoint to_widget(Gfx::IntPoint) const;
signals: signals:
void linkHovered(QString, int timeout = 0); void link_hovered(QString, int timeout = 0);
void linkUnhovered(); void link_unhovered();
void loadStarted(const URL&); void load_started(const URL&);
void title_changed(QString); void title_changed(QString);
void favicon_changed(QIcon); void favicon_changed(QIcon);