RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 03:22:43 +00:00
Code Issues Activity Actions

HackStudio: Pass the correct VariableInfo address to create_index

Browse source 
Previously, we tried to store `VariableInfo` to `ModelIndex` internal
data, but accidently stored address of wrapper class `NonnullOwnPtr`.
When we retrieved it later in `VariablesModel::data()` it made
program to crash.

This allows us to run debug normally after setting any break point in
`HackStudio`.
This commit is contained in:
hanaa12G 2023-10-29 16:42:45 +07:00 • committed by Sam Atkins
parent 7e6722abe8
commit 0391096286
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp
View file

@ -15,7 +15,7 @@ GUI::ModelIndex VariablesModel::index(int row, int column, const GUI::ModelIndex
if (!parent_index.is_valid()) {
if (static_cast<size_t>(row) >= m_variables.size())
return {};
return create_index(row, column, &m_variables[row]);
return create_index(row, column, m_variables[row].ptr());
}
auto* parent = static_cast<Debug::DebugInfo::VariableInfo const*>(parent_index.internal_data());
if (static_cast<size_t>(row) >= parent->members.size())