RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

LibJS: Swap until/since arguments to DifferenceTemporalZonedDateTime

Browse source 
This is an editorial change in the Temporal spec.

See: b911bc9
This commit is contained in:
Linus Groh 2022-05-16 20:35:13 +01:00
parent 6d7970a23c
commit 0558eb6d2f
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp
View file

@ -244,8 +244,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::until)
// 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]).
auto* temporal_time = TRY(typed_this_object(global_object));
// 3. Return ? DifferenceTemporalPlainTime(since, temporalTime, other, options).
// FIXME: until, not since (spec issue, see https://github.com/tc39/proposal-temporal/pull/2183)
// 3. Return ? DifferenceTemporalPlainTime(until, temporalTime, other, options).
return TRY(difference_temporal_plain_time(global_object, DifferenceOperation::Until, *temporal_time, other, options));
}
@ -259,8 +258,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::since)
// 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]).
auto* temporal_time = TRY(typed_this_object(global_object));
// 3. Return ? DifferenceTemporalPlainTime(until, temporalTime, other, options).
// FIXME: since, not until (spec issue, see https://github.com/tc39/proposal-temporal/pull/2183)
// 3. Return ? DifferenceTemporalPlainTime(since, temporalTime, other, options).
return TRY(difference_temporal_plain_time(global_object, DifferenceOperation::Since, *temporal_time, other, options));
}