RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibWeb: Call requestAnimationFrame() callback with undefined this value

Browse source 
We were leaking an empty value via the callback's this value:

    requestAnimationFrame(function () {
        this; // <-- empty value
    });
This commit is contained in:
Linus Groh 2021-03-26 19:35:54 +01:00 • committed by Andreas Kling
parent 49a062f81d
commit 056ffa4abb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Window.cpp
View file

@ -140,7 +140,7 @@ i32 Window::request_animation_frame(JS::Function& callback)
auto& function = const_cast<JS::Function&>(static_cast<const JS::Function&>(*handle.cell())); auto& function = const_cast<JS::Function&>(static_cast<const JS::Function&>(*handle.cell()));
auto& vm = function.vm(); auto& vm = function.vm();
fake_timestamp += 10; fake_timestamp += 10;
[[maybe_unused]] auto rc = vm.call(function, {}, JS::Value(fake_timestamp)); [[maybe_unused]] auto rc = vm.call(function, JS::js_undefined(), JS::Value(fake_timestamp));
if (vm.exception()) if (vm.exception())
vm.clear_exception(); vm.clear_exception();
GUI::DisplayLink::unregister_callback(link_id); GUI::DisplayLink::unregister_callback(link_id);