RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:27:43 +00:00
Code Issues Activity Actions

Kernel: Pass InodeMetadata by reference in TmpFSInode::create

Browse source 
This struct is non-trivially large, it makes sense to pass it by
reference instead of by value in the factory method.

Found by Sonar Cloud.
This commit is contained in:
Brian Gianforcaro 2021-08-31 22:15:44 -07:00 • committed by Andreas Kling
parent fee2a03ba9
commit 0678ac265c
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/TmpFS.h
View file

@ -70,8 +70,8 @@ public:
virtual void one_ref_left() override;
private:
TmpFSInode(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent);
static RefPtr<TmpFSInode> create(TmpFS&, InodeMetadata metadata, InodeIdentifier parent);
TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent);
static RefPtr<TmpFSInode> create(TmpFS&, const InodeMetadata& metadata, InodeIdentifier parent);
static RefPtr<TmpFSInode> create_root(TmpFS&);
void notify_watchers();