RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

Kernel: Pass InodeMetadata by reference in TmpFSInode::create

Browse source 
This struct is non-trivially large, it makes sense to pass it by
reference instead of by value in the factory method.

Found by Sonar Cloud.
This commit is contained in:
Brian Gianforcaro 2021-08-31 22:15:44 -07:00 • committed by Andreas Kling
parent fee2a03ba9
commit 0678ac265c
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/TmpFS.cpp
View file

@ -72,7 +72,7 @@ RefPtr<Inode> TmpFS::get_inode(InodeIdentifier identifier) const
return it->value; return it->value;
} }
TmpFSInode::TmpFSInode(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent) TmpFSInode::TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent)
: Inode(fs, fs.next_inode_index()) : Inode(fs, fs.next_inode_index())
, m_metadata(metadata) , m_metadata(metadata)
, m_parent(parent) , m_parent(parent)
@ -84,7 +84,7 @@ TmpFSInode::~TmpFSInode()
{ {
} }
RefPtr<TmpFSInode> TmpFSInode::create(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent) RefPtr<TmpFSInode> TmpFSInode::create(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent)
{ {
auto inode = adopt_ref_if_nonnull(new (nothrow) TmpFSInode(fs, metadata, parent)); auto inode = adopt_ref_if_nonnull(new (nothrow) TmpFSInode(fs, metadata, parent));
if (inode) if (inode)

4
Kernel/FileSystem/TmpFS.h
View file

@ -70,8 +70,8 @@ public:
virtual void one_ref_left() override; virtual void one_ref_left() override;
private: private:
TmpFSInode(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent); TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent);
static RefPtr<TmpFSInode> create(TmpFS&, InodeMetadata metadata, InodeIdentifier parent); static RefPtr<TmpFSInode> create(TmpFS&, const InodeMetadata& metadata, InodeIdentifier parent);
static RefPtr<TmpFSInode> create_root(TmpFS&); static RefPtr<TmpFSInode> create_root(TmpFS&);
void notify_watchers(); void notify_watchers();