RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibGfx/TIFF: Don't include the null-byte terminator when reading strings

Browse source
This commit is contained in:
Lucas CHOLLET 2023-12-02 18:00:40 -05:00 • committed by Andreas Kling
parent a382ea7c1f
commit 0a80daef90
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
View file

@ -378,6 +378,9 @@ private:
case Type::ASCII: case Type::ASCII:
case Type::UTF8: { case Type::UTF8: {
Vector<Value, 1> result; Vector<Value, 1> result;
// NOTE: No need to include the null terminator
if (count > 0)
--count;
auto string_data = TRY(ByteBuffer::create_uninitialized(count)); auto string_data = TRY(ByteBuffer::create_uninitialized(count));
TRY(m_stream->read_until_filled(string_data)); TRY(m_stream->read_until_filled(string_data));
result.empend(TRY(String::from_utf8(StringView { string_data.bytes() }))); result.empend(TRY(String::from_utf8(StringView { string_data.bytes() })));