RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:37:46 +00:00
Code Issues Activity Actions

WindowServer: Stop spurious debug spam after flushing the framebuffer

Browse source 
This became apparent when using the VirtIO graphics device, because the
HardwareScreenBackend object needs to allow flushing of the framebuffer
constantly, and due to incorrect if-else flow, even a non-error response
from the ioctl was leading to a debug spam.
This commit is contained in:
Liav A 2022-05-06 15:29:24 +03:00 • committed by Linus Groh
parent 6668077965
commit 102ac09ad7
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WindowServer/HardwareScreenBackend.cpp
View file

@ -143,7 +143,7 @@ ErrorOr<void> HardwareScreenBackend::flush_framebuffer_rects(int buffer_index, S
int rc = fb_flush_buffers(m_framebuffer_fd, buffer_index, flush_rects.data(), (unsigned)flush_rects.size());
if (rc == -ENOTSUP)
m_can_device_flush_buffers = false;
else
else if (rc != 0)
return Error::from_syscall("fb_flush_buffers", rc);
return {};
}
@ -153,7 +153,7 @@ ErrorOr<void> HardwareScreenBackend::flush_framebuffer()
int rc = fb_flush_head(m_framebuffer_fd);
if (rc == -ENOTSUP)
m_can_device_flush_entire_framebuffer = false;
else
else if (rc != 0)
return Error::from_syscall("fb_flush_head", rc);
return {};
}