RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 17:25:10 +00:00
Code Issues Activity Actions

LibWeb: Use DOMParserSupportedType enum for DOMParser.parseFromString

Browse source 
Previously it would accept any DOMString, as we didn't support enums at
the time. Now it will only accept what's specified in the
DOMParserSupportedType enum.

This also adds spec comments to DOMParser::parse_from_string.
This commit is contained in:
Luke Wilde 2022-02-19 20:01:20 +00:00 • committed by Andreas Kling
parent a65e1fa828
commit 10581cfaeb
4 changed files with 36 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Libraries/LibWeb/HTML/DOMParser.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/DOMParserWrapper.h>
#include <LibWeb/HTML/DOMParser.h>
#include <LibWeb/HTML/Parser/HTMLParser.h>
@ -18,23 +19,41 @@ DOMParser::~DOMParser()
}
// https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-domparser-parsefromstring
NonnullRefPtr<DOM::Document> DOMParser::parse_from_string(String const& string, String const& type)
NonnullRefPtr<DOM::Document> DOMParser::parse_from_string(String const& string, Bindings::DOMParserSupportedType type)
{
// 1. Let document be a new Document, whose content type is type and url is this's relevant global object's associated Document's URL.
// FIXME: Pass in this's relevant global object's associated Document's URL.
auto document = DOM::Document::create();
document->set_content_type(type);
document->set_content_type(Bindings::idl_enum_to_string(type));
// NOTE: This isn't a case insensitive match since the DOMParserSupportedType enum enforces an all lowercase type.
if (type == "text/html") {
// FIXME: Set document's type to "html".
// 2. Switch on type:
if (type == Bindings::DOMParserSupportedType::Text_Html) {
// -> "text/html"
// FIXME: 1. Set document's type to "html".
// 2. Create an HTML parser parser, associated with document.
// 3. Place string into the input stream for parser. The encoding confidence is irrelevant.
// FIXME: We don't have the concept of encoding confidence yet.
HTMLParser parser(document, string, "UTF-8");
// 4. Start parser and let it run until it has consumed all the characters just inserted into the input stream.
// FIXME: This is to match the default URL. Instead, pass in this's relevant global object's associated Document's URL.
parser.run("about:blank");
} else {
dbgln("DOMParser::parse_from_string: Unimplemented parser for type: {}", type);
// -> Otherwise
// FIXME: 1. Create an XML parser parse, associated with document, and with XML scripting support disabled.
// 2. Parse string using parser.
// 3. If the previous step resulted in an XML well-formedness or XML namespace well-formedness error, then:
// 1. Assert: document has no child nodes.
// 2. Let root be the result of creating an element given document, "parsererror", and "http://www.mozilla.org/newlayout/xml/parsererror.xml".
// 3. Optionally, add attributes or children to root to describe the nature of the parsing error.
// 4. Append root to document.
dbgln("DOMParser::parse_from_string: Unimplemented parser for type: {}", Bindings::idl_enum_to_string(type));
TODO();
}
// 3. Return document.
return document;
}