RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 23:48:11 +00:00
Code Issues Activity Actions

LibJS: Remove FIXME comment from PartitionNotationSubPattern AO

Browse source 
All possible patterns generated by LibUnicode are now handled. We have a
similar VERIFY_NOT_REACHED in PartitionNumberPattern.
This commit is contained in:
Timothy Flynn 2021-11-15 11:38:23 -05:00 • committed by Linus Groh
parent fdae323401
commit 14aca03161
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp
View file

@ -992,7 +992,8 @@ Vector<PatternPartition> partition_notation_sub_pattern(NumberFormat& number_for
// 1. Let unknown be an ILND String based on x and p.
// 2. Append a new Record { [[Type]]: "unknown", [[Value]]: unknown } as the last element of result.
// FIXME: Implement this when GetNotationSubPattern is fully implemented.
// LibUnicode doesn't generate any "unknown" patterns.
VERIFY_NOT_REACHED();
}
}
}