RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:47:44 +00:00
Code Issues Activity Actions

UserspaceEmulator: Add some implied auto qualifiers

Browse source
This commit is contained in:
Hendiadyoin1 2021-12-22 16:20:22 +01:00 • committed by Brian Gianforcaro
parent bf714efa41
commit 15daae468b
5 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -102,14 +102,14 @@ void Emulator::setup_stack(Vector<ELF::AuxiliaryValue> aux_vector)
Vector<u32> argv_entries; Vector<u32> argv_entries;
for (auto& argument : m_arguments) { for (auto const& argument : m_arguments) {
m_cpu.push_string(argument); m_cpu.push_string(argument);
argv_entries.append(m_cpu.esp().value()); argv_entries.append(m_cpu.esp().value());
} }
Vector<u32> env_entries; Vector<u32> env_entries;
for (auto& variable : m_environment) { for (auto const& variable : m_environment) {
m_cpu.push_string(variable.characters()); m_cpu.push_string(variable.characters());
env_entries.append(m_cpu.esp().value()); env_entries.append(m_cpu.esp().value());
} }
@ -461,7 +461,7 @@ String Emulator::create_backtrace_line(FlatPtr address)
void Emulator::dump_backtrace(Vector<FlatPtr> const& backtrace) void Emulator::dump_backtrace(Vector<FlatPtr> const& backtrace)
{ {
for (auto& address : backtrace) { for (auto const& address : backtrace) {
reportln("{}", create_backtrace_line(address)); reportln("{}", create_backtrace_line(address));
} }
} }

2
Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
View file

@ -1493,7 +1493,7 @@ int Emulator::virt$clock_nanosleep(FlatPtr params_addr)
mmu().copy_from_vm(&requested_sleep, (FlatPtr)params.requested_sleep, sizeof(timespec)); mmu().copy_from_vm(&requested_sleep, (FlatPtr)params.requested_sleep, sizeof(timespec));
params.requested_sleep = &requested_sleep; params.requested_sleep = &requested_sleep;
auto remaining_vm_addr = params.remaining_sleep; auto* remaining_vm_addr = params.remaining_sleep;
timespec remaining { 0, 0 }; timespec remaining { 0, 0 };
params.remaining_sleep = &remaining; params.remaining_sleep = &remaining;

8
Userland/DevTools/UserspaceEmulator/MmapRegion.cpp
View file

@ -27,8 +27,8 @@ static void free_pages(void* ptr, size_t bytes)
NonnullOwnPtr<MmapRegion> MmapRegion::create_anonymous(u32 base, u32 size, u32 prot, String name) NonnullOwnPtr<MmapRegion> MmapRegion::create_anonymous(u32 base, u32 size, u32 prot, String name)
{ {
auto data = (u8*)mmap_initialized(size, 0, String::formatted("(UE) {}", name).characters()); auto* data = (u8*)mmap_initialized(size, 0, String::formatted("(UE) {}", name).characters());
auto shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); auto* shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData");
auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data)); auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data));
region->m_name = move(name); region->m_name = move(name);
return region; return region;
@ -38,9 +38,9 @@ NonnullOwnPtr<MmapRegion> MmapRegion::create_file_backed(u32 base, u32 size, u32
{ {
// Since we put the memory to an arbitrary location, do not pass MAP_FIXED to the Kernel. // Since we put the memory to an arbitrary location, do not pass MAP_FIXED to the Kernel.
auto real_flags = flags & ~MAP_FIXED; auto real_flags = flags & ~MAP_FIXED;
auto data = (u8*)mmap_with_name(nullptr, size, prot, real_flags, fd, offset, name.is_empty() ? nullptr : String::formatted("(UE) {}", name).characters()); auto* data = (u8*)mmap_with_name(nullptr, size, prot, real_flags, fd, offset, name.is_empty() ? nullptr : String::formatted("(UE) {}", name).characters());
VERIFY(data != MAP_FAILED); VERIFY(data != MAP_FAILED);
auto shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData"); auto* shadow_data = (u8*)mmap_initialized(size, 1, "MmapRegion ShadowData");
auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data)); auto region = adopt_own(*new MmapRegion(base, size, prot, data, shadow_data));
region->m_file_backed = true; region->m_file_backed = true;
region->m_name = move(name); region->m_name = move(name);

2
Userland/DevTools/UserspaceEmulator/RangeAllocator.cpp
View file

@ -28,7 +28,7 @@ void RangeAllocator::initialize_with_range(VirtualAddress base, size_t size)
void RangeAllocator::dump() const void RangeAllocator::dump() const
{ {
dbgln("RangeAllocator({})", this); dbgln("RangeAllocator({})", this);
for (auto& range : m_available_ranges) { for (auto const& range : m_available_ranges) {
dbgln(" {:x} -> {:x}", range.base().get(), range.end().get() - 1); dbgln(" {:x} -> {:x}", range.base().get(), range.end().get() - 1);
} }
} }

2
Userland/DevTools/UserspaceEmulator/main.cpp
View file

@ -65,7 +65,7 @@ int main(int argc, char** argv, char** env)
if (dump_profile) { if (dump_profile) {
profile_output_file = fopen(profile_dump_path.characters(), "w+"); profile_output_file = fopen(profile_dump_path.characters(), "w+");
if (profile_output_file == nullptr) { if (profile_output_file == nullptr) {
auto error_string = strerror(errno); char const* error_string = strerror(errno);
warnln("Failed to open '{}' for writing: {}", profile_dump_path, error_string); warnln("Failed to open '{}' for writing: {}", profile_dump_path, error_string);
return 1; return 1;
} }