RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

Revert "Assistant: Check for access before showing results"

Browse source 
This reverts commit 7c88ab2836.

Post-merge review revealed that the checks added in this PR prevent
any and all non-executable files from being displayed in Assistant,
which is a regression from intended functionality.
This commit is contained in:
Andrew Kaster 2024-01-14 15:51:32 -07:00
parent 7dba28fce8
commit 162c334508
1 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/Assistant/Providers.cpp
View file

@ -66,9 +66,7 @@ void URLResult::activate() const
AppProvider::AppProvider() AppProvider::AppProvider()
{ {
Desktop::AppFile::for_each([this](NonnullRefPtr<Desktop::AppFile> app_file) { Desktop::AppFile::for_each([this](NonnullRefPtr<Desktop::AppFile> app_file) {
if (access(app_file->executable().characters(), X_OK) == 0) {
m_app_file_cache.append(move(app_file)); m_app_file_cache.append(move(app_file));
}
}); });
} }
@ -226,10 +224,6 @@ void FileProvider::build_filesystem_cache()
return IterationDecision::Continue; return IterationDecision::Continue;
auto full_path = LexicalPath::join(directory.path().string(), entry.name).string(); auto full_path = LexicalPath::join(directory.path().string(), entry.name).string();
if (access(full_path.characters(), X_OK) != 0)
return IterationDecision::Continue;
m_full_path_cache.append(full_path); m_full_path_cache.append(full_path);
if (S_ISDIR(st.st_mode)) { if (S_ISDIR(st.st_mode)) {