RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

LibJS: Make sure private identifier is valid in optional chain

Browse source 
If we don't check that a private identifier is valid this can break the
assumption that we have a private environment when evaluation the
private identifier. Also an unknown private identifier this should
be a SyntaxError.
This commit is contained in:
davidot 2022-11-17 10:24:20 +01:00 • committed by Linus Groh
parent 49fc0e2514
commit 16ac43c9d4
2 changed files with 38 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Userland/Libraries/LibJS/Tests/classes/class-private-fields.js
View file

@ -148,3 +148,38 @@ test("using 'arguments' via indirect eval throws at runtime instead of parse tim
}
}).toThrowWithMessage(ReferenceError, "'arguments' is not defined");
});
test("unknown private name gives SyntaxError", () => {
expect(`#n`).not.toEval();
expect(`obj.#n`).not.toEval();
expect(`this.#n`).not.toEval();
expect(`if (#n) 1;`).not.toEval();
expect(`1?.#n`).not.toEval();
expect(`1?.n.#n`).not.toEval();
});
// OSS-FUZZ Issue 53363: top level unknown private names seg faults
expect(() => eval(`#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`obj.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`this.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`if (#n) 1;`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`1?.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`1?.n.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);