mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 02:47:34 +00:00
LibJS: Make sure private identifier is valid in optional chain
If we don't check that a private identifier is valid this can break the assumption that we have a private environment when evaluation the private identifier. Also an unknown private identifier this should be a SyntaxError.
This commit is contained in:
parent
49fc0e2514
commit
16ac43c9d4
2 changed files with 38 additions and 0 deletions
|
@ -3174,6 +3174,9 @@ NonnullRefPtr<OptionalChain> Parser::parse_optional_chain(NonnullRefPtr<Expressi
|
||||||
} else if (match(TokenType::Period)) {
|
} else if (match(TokenType::Period)) {
|
||||||
consume();
|
consume();
|
||||||
if (match(TokenType::PrivateIdentifier)) {
|
if (match(TokenType::PrivateIdentifier)) {
|
||||||
|
if (!is_private_identifier_valid())
|
||||||
|
syntax_error(String::formatted("Reference to undeclared private field or method '{}'", m_state.current_token.value()));
|
||||||
|
|
||||||
auto start = position();
|
auto start = position();
|
||||||
auto private_identifier = consume();
|
auto private_identifier = consume();
|
||||||
chain.append(OptionalChain::PrivateMemberReference {
|
chain.append(OptionalChain::PrivateMemberReference {
|
||||||
|
|
|
@ -148,3 +148,38 @@ test("using 'arguments' via indirect eval throws at runtime instead of parse tim
|
||||||
}
|
}
|
||||||
}).toThrowWithMessage(ReferenceError, "'arguments' is not defined");
|
}).toThrowWithMessage(ReferenceError, "'arguments' is not defined");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("unknown private name gives SyntaxError", () => {
|
||||||
|
expect(`#n`).not.toEval();
|
||||||
|
expect(`obj.#n`).not.toEval();
|
||||||
|
expect(`this.#n`).not.toEval();
|
||||||
|
expect(`if (#n) 1;`).not.toEval();
|
||||||
|
expect(`1?.#n`).not.toEval();
|
||||||
|
expect(`1?.n.#n`).not.toEval();
|
||||||
|
});
|
||||||
|
|
||||||
|
// OSS-FUZZ Issue 53363: top level unknown private names seg faults
|
||||||
|
expect(() => eval(`#n`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
expect(() => eval(`obj.#n`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
expect(() => eval(`this.#n`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
expect(() => eval(`if (#n) 1;`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
expect(() => eval(`1?.#n`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
expect(() => eval(`1?.n.#n`)).toThrowWithMessage(
|
||||||
|
SyntaxError,
|
||||||
|
"Reference to undeclared private field or method '#n'"
|
||||||
|
);
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue