RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 10:27:35 +00:00
Code Issues Activity Actions

Kernel: Call try_set_coredump_property with StringView arguments

Browse source 
Storing assigning a string literal to a String object just to pass it to
a function expecting a StringView is wasteful. Let's just not do that.

For consistency's sake, this commit changes all of the other invocations
to use StringView literals, too.
This commit is contained in:
Daniel Bertalan 2021-10-21 20:02:57 +02:00 • committed by Andreas Kling
parent bbb4eb0aa1
commit 17b66eaa3c
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Kernel/Arch/x86/common/Interrupts.cpp
View file

@ -403,14 +403,14 @@ void page_fault_handler(TrapFrame* trap)
if (current_thread) { if (current_thread) {
auto& current_process = current_thread->process(); auto& current_process = current_thread->process();
if (current_process.is_user_process()) { if (current_process.is_user_process()) {
(void)current_process.try_set_coredump_property("fault_address", String::formatted("{:p}", fault_address)); (void)current_process.try_set_coredump_property("fault_address"sv, String::formatted("{:p}", fault_address));
(void)current_process.try_set_coredump_property("fault_type", fault.type() == PageFault::Type::PageNotPresent ? "NotPresent" : "ProtectionViolation"); (void)current_process.try_set_coredump_property("fault_type"sv, fault.type() == PageFault::Type::PageNotPresent ? "NotPresent"sv : "ProtectionViolation"sv);
String fault_access; StringView fault_access;
if (fault.is_instruction_fetch()) if (fault.is_instruction_fetch())
fault_access = "Execute"; fault_access = "Execute"sv;
else else
fault_access = fault.access() == PageFault::Access::Read ? "Read" : "Write"; fault_access = fault.access() == PageFault::Access::Read ? "Read"sv : "Write"sv;
(void)current_process.try_set_coredump_property("fault_access", fault_access); (void)current_process.try_set_coredump_property("fault_access"sv, fault_access);
} }
} }