RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

Kernel: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-16 13:15:15 -06:00 • committed by Brian Gianforcaro
parent 68f75ab98e
commit 190cf1507b
79 changed files with 102 additions and 309 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Net/Intel/E1000ENetworkAdapter.cpp
View file

@ -238,9 +238,7 @@ UNMAP_AFTER_INIT E1000ENetworkAdapter::E1000ENetworkAdapter(PCI::Address address
{
}
UNMAP_AFTER_INIT E1000ENetworkAdapter::~E1000ENetworkAdapter()
{
}
UNMAP_AFTER_INIT E1000ENetworkAdapter::~E1000ENetworkAdapter() = default;
UNMAP_AFTER_INIT void E1000ENetworkAdapter::detect_eeprom()
{

4
Kernel/Net/Intel/E1000NetworkAdapter.cpp
View file

@ -236,9 +236,7 @@ UNMAP_AFTER_INIT E1000NetworkAdapter::E1000NetworkAdapter(PCI::Address address,
{
}
UNMAP_AFTER_INIT E1000NetworkAdapter::~E1000NetworkAdapter()
{
}
UNMAP_AFTER_INIT E1000NetworkAdapter::~E1000NetworkAdapter() = default;
bool E1000NetworkAdapter::handle_irq(const RegisterState&)
{

4
Kernel/Net/LoopbackAdapter.cpp
View file

@ -28,9 +28,7 @@ LoopbackAdapter::LoopbackAdapter(NonnullOwnPtr<KString> interface_name)
set_mac_address({ 19, 85, 2, 9, 0x55, 0xaa });
}
LoopbackAdapter::~LoopbackAdapter()
{
}
LoopbackAdapter::~LoopbackAdapter() = default;
void LoopbackAdapter::send_raw(ReadonlyBytes payload)
{

4
Kernel/Net/NE2000/NetworkAdapter.cpp
View file

@ -185,9 +185,7 @@ UNMAP_AFTER_INIT NE2000NetworkAdapter::NE2000NetworkAdapter(PCI::Address address
enable_irq();
}
UNMAP_AFTER_INIT NE2000NetworkAdapter::~NE2000NetworkAdapter()
{
}
UNMAP_AFTER_INIT NE2000NetworkAdapter::~NE2000NetworkAdapter() = default;
bool NE2000NetworkAdapter::handle_irq(const RegisterState&)
{

4
Kernel/Net/NetworkAdapter.cpp
View file

@ -19,9 +19,7 @@ NetworkAdapter::NetworkAdapter(NonnullOwnPtr<KString> interface_name)
{
}
NetworkAdapter::~NetworkAdapter()
{
}
NetworkAdapter::~NetworkAdapter() = default;
void NetworkAdapter::send_packet(ReadonlyBytes packet)
{

4
Kernel/Net/Realtek/RTL8139NetworkAdapter.cpp
View file

@ -162,9 +162,7 @@ UNMAP_AFTER_INIT RTL8139NetworkAdapter::RTL8139NetworkAdapter(PCI::Address addre
enable_irq();
}
UNMAP_AFTER_INIT RTL8139NetworkAdapter::~RTL8139NetworkAdapter()
{
}
UNMAP_AFTER_INIT RTL8139NetworkAdapter::~RTL8139NetworkAdapter() = default;
bool RTL8139NetworkAdapter::handle_irq(const RegisterState&)
{

4
Kernel/Net/Realtek/RTL8168NetworkAdapter.cpp
View file

@ -1125,9 +1125,7 @@ UNMAP_AFTER_INIT void RTL8168NetworkAdapter::initialize_tx_descriptors()
tx_descriptors[number_of_tx_descriptors - 1].flags = tx_descriptors[number_of_tx_descriptors - 1].flags | TXDescriptor::EndOfRing;
}
UNMAP_AFTER_INIT RTL8168NetworkAdapter::~RTL8168NetworkAdapter()
{
}
UNMAP_AFTER_INIT RTL8168NetworkAdapter::~RTL8168NetworkAdapter() = default;
bool RTL8168NetworkAdapter::handle_irq(const RegisterState&)
{

4
Kernel/Net/Socket.cpp
View file

@ -37,9 +37,7 @@ Socket::Socket(int domain, int type, int protocol)
set_origin(Process::current());
}
Socket::~Socket()
{
}
Socket::~Socket() = default;
void Socket::set_setup_state(SetupState new_setup_state)
{