RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:07:45 +00:00
Code Issues Activity Actions

Kernel: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-16 13:15:15 -06:00 • committed by Brian Gianforcaro
parent 68f75ab98e
commit 190cf1507b
79 changed files with 102 additions and 309 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Storage/ATA/AHCIController.cpp
View file

@ -135,9 +135,7 @@ NonnullOwnPtr<Memory::Region> AHCIController::default_hba_region() const
return MM.allocate_kernel_region(PhysicalAddress(PCI::get_BAR5(pci_address())).page_base(), Memory::page_round_up(sizeof(AHCI::HBA)).release_value_but_fixme_should_propagate_errors(), "AHCI HBA", Memory::Region::Access::ReadWrite).release_value();
}
AHCIController::~AHCIController()
{
}
AHCIController::~AHCIController() = default;
void AHCIController::initialize_hba(PCI::DeviceIdentifier const& pci_device_identifier)
{

4
Kernel/Storage/ATA/AHCIPortHandler.cpp
View file

@ -78,9 +78,7 @@ AHCI::HBADefinedCapabilities AHCIPortHandler::hba_capabilities() const
return m_parent_controller->hba_capabilities();
}
AHCIPortHandler::~AHCIPortHandler()
{
}
AHCIPortHandler::~AHCIPortHandler() = default;
bool AHCIPortHandler::handle_irq(const RegisterState&)
{

4
Kernel/Storage/ATA/ATADevice.cpp
View file

@ -21,9 +21,7 @@ ATADevice::ATADevice(const ATAController& controller, ATADevice::Address ata_add
{
}
ATADevice::~ATADevice()
{
}
ATADevice::~ATADevice() = default;
void ATADevice::start_request(AsyncBlockDeviceRequest& request)
{

4
Kernel/Storage/ATA/ATADiskDevice.cpp
View file

@ -31,9 +31,7 @@ ATADiskDevice::ATADiskDevice(const ATAController& controller, ATADevice::Address
{
}
ATADiskDevice::~ATADiskDevice()
{
}
ATADiskDevice::~ATADiskDevice() = default;
StringView ATADiskDevice::class_name() const
{

4
Kernel/Storage/ATA/ATAPIDiscDevice.cpp
View file

@ -31,9 +31,7 @@ ATAPIDiscDevice::ATAPIDiscDevice(const ATAController& controller, ATADevice::Add
{
}
ATAPIDiscDevice::~ATAPIDiscDevice()
{
}
ATAPIDiscDevice::~ATAPIDiscDevice() = default;
StringView ATAPIDiscDevice::class_name() const
{

4
Kernel/Storage/ATA/IDEChannel.cpp
View file

@ -100,9 +100,7 @@ void IDEChannel::clear_pending_interrupts() const
m_io_group.io_base().offset(ATA_REG_STATUS).in<u8>();
}
UNMAP_AFTER_INIT IDEChannel::~IDEChannel()
{
}
UNMAP_AFTER_INIT IDEChannel::~IDEChannel() = default;
void IDEChannel::start_request(AsyncBlockDeviceRequest& request, bool is_slave, u16 capabilities)
{

4
Kernel/Storage/ATA/IDEController.cpp
View file

@ -65,9 +65,7 @@ UNMAP_AFTER_INIT IDEController::IDEController()
{
}
UNMAP_AFTER_INIT IDEController::~IDEController()
{
}
UNMAP_AFTER_INIT IDEController::~IDEController() = default;
RefPtr<StorageDevice> IDEController::device_by_channel_and_position(u32 index) const
{

4
Kernel/Storage/NVMe/NVMeQueue.cpp
View file

@ -172,7 +172,5 @@ void NVMeQueue::write(AsyncBlockDeviceRequest& request, u16 nsid, u64 index, u32
submit_sqe(sub);
}
UNMAP_AFTER_INIT NVMeQueue::~NVMeQueue()
{
}
UNMAP_AFTER_INIT NVMeQueue::~NVMeQueue() = default;
}

4
Kernel/Storage/Partition/DiskPartition.cpp
View file

@ -26,9 +26,7 @@ DiskPartition::DiskPartition(BlockDevice& device, unsigned minor_number, DiskPar
{
}
DiskPartition::~DiskPartition()
{
}
DiskPartition::~DiskPartition() = default;
const DiskPartitionMetadata& DiskPartition::metadata() const
{

4
Kernel/Storage/Partition/EBRPartitionTable.cpp
View file

@ -68,8 +68,6 @@ EBRPartitionTable::EBRPartitionTable(const StorageDevice& device)
}
}
EBRPartitionTable::~EBRPartitionTable()
{
}
EBRPartitionTable::~EBRPartitionTable() = default;
}

4
Kernel/Storage/Partition/MBRPartitionTable.cpp
View file

@ -84,9 +84,7 @@ MBRPartitionTable::MBRPartitionTable(const StorageDevice& device)
m_valid = true;
}
MBRPartitionTable::~MBRPartitionTable()
{
}
MBRPartitionTable::~MBRPartitionTable() = default;
const MBRPartitionTable::Header& MBRPartitionTable::header() const
{

4
Kernel/Storage/RamdiskController.cpp
View file

@ -55,9 +55,7 @@ RamdiskController::RamdiskController()
}
}
RamdiskController::~RamdiskController()
{
}
RamdiskController::~RamdiskController() = default;
RefPtr<StorageDevice> RamdiskController::device(u32 index) const
{

4
Kernel/Storage/RamdiskDevice.cpp
View file

@ -32,9 +32,7 @@ RamdiskDevice::RamdiskDevice(const RamdiskController&, NonnullOwnPtr<Memory::Reg
dmesgln("Ramdisk: Device #{} @ {}, Capacity={}", minor, m_region->vaddr(), max_addressable_block() * 512);
}
RamdiskDevice::~RamdiskDevice()
{
}
RamdiskDevice::~RamdiskDevice() = default;
StringView RamdiskDevice::class_name() const
{