RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:57:34 +00:00
Code Issues Activity Actions

DisplaySettings: Remove unnecessary file open for non-paths

Browse source 
Currently, every time the wallpaper picker changes, an additional
attempted file load happens on top of the file load to create the
bitmap. The only values that the wallpaper picker can take on are
filenames that can never be valid when loaded without the /res/wallpaper
prefix. To reduce the amount of log spam and speed up wallpaper picking,
this patch only attempts to load wallpapers with slash-prefixed names,
assumed to be the absolute path to that wallpaper. Additional wallpapers
outside of /res/wallpapers/ should still be accessible with this patch,
and the experience is improved for the more common case of selecting a
built-in wallpaper.
This commit is contained in:
Avery 2020-09-02 20:53:49 -06:00 • committed by Andreas Kling
parent 6fe37cb471
commit 1da38eeb3c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/DisplaySettings/DisplaySettings.cpp
View file

@ -125,7 +125,7 @@ void DisplaySettingsWidget::create_frame()
m_wallpaper_combo->set_model(*GUI::ItemListModel<AK::String>::create(m_wallpapers));
m_wallpaper_combo->on_change = [this](auto& text, const GUI::ModelIndex& index) {
String path = text;
if (m_monitor_widget->set_wallpaper(path)) {
if (path.starts_with("/") && m_monitor_widget->set_wallpaper(path)) {
m_monitor_widget->update();
return;
}