RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibWeb: Make about:blank load correctly

Browse source 
- Don't treat an empty `about:blank` resource as an error.
- Give `about:` urls a content-type so `FrameLoader::parse_document()`
  won't reject them.
This commit is contained in:
Sam Atkins 2022-05-13 11:45:21 +01:00 • committed by Linus Groh
parent 61a9ad45ed
commit 1f82beded3
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -331,7 +331,7 @@ void FrameLoader::resource_did_load()
} }
m_redirects_count = 0; m_redirects_count = 0;
if (!resource()->has_encoded_data()) { if (!resource()->has_encoded_data() && url.to_string() != "about:blank") {
load_error_page(url, "No data"); load_error_page(url, "No data");
return; return;
} }

8
Userland/Libraries/LibWeb/Loader/ResourceLoader.cpp
View file

@ -150,8 +150,12 @@ void ResourceLoader::load(LoadRequest& request, Function<void(ReadonlyBytes, Has
if (url.protocol() == "about") { if (url.protocol() == "about") {
dbgln_if(SPAM_DEBUG, "Loading about: URL {}", url); dbgln_if(SPAM_DEBUG, "Loading about: URL {}", url);
log_success(request); log_success(request);
deferred_invoke([success_callback = move(success_callback)] {
success_callback(String::empty().to_byte_buffer(), {}, {}); HashMap<String, String, CaseInsensitiveStringTraits> response_headers;
response_headers.set("Content-Type", "text/html; charset=UTF-8");
deferred_invoke([success_callback = move(success_callback), response_headers = move(response_headers)] {
success_callback(String::empty().to_byte_buffer(), response_headers, {});
}); });
return; return;
} }