RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 18:25:06 +00:00
Code Issues Activity Actions

LibHTML: Ignore case of presentation attribute names

Browse source
This commit is contained in:
Andreas Kling 2019-12-18 12:44:13 +01:00
parent 4d81bc20d8
commit 1fda417f4f
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibHTML/DOM/HTMLBodyElement.cpp
View file

@ -15,15 +15,15 @@ HTMLBodyElement::~HTMLBodyElement()
void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const
{ {
for_each_attribute([&](auto& name, auto& value) { for_each_attribute([&](auto& name, auto& value) {
if (name == "bgcolor") { if (name.equals_ignoring_case("bgcolor")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
style.set_property(CSS::PropertyID::BackgroundColor, ColorStyleValue::create(color.value())); style.set_property(CSS::PropertyID::BackgroundColor, ColorStyleValue::create(color.value()));
} else if (name == "text") { } else if (name.equals_ignoring_case("text")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value())); style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value()));
} else if (name == "background") { } else if (name.equals_ignoring_case("background")) {
style.set_property(CSS::PropertyID::BackgroundImage, ImageStyleValue::create(document().complete_url(value), const_cast<Document&>(document()))); style.set_property(CSS::PropertyID::BackgroundImage, ImageStyleValue::create(document().complete_url(value), const_cast<Document&>(document())));
} }
}); });
@ -31,15 +31,15 @@ void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const
void HTMLBodyElement::parse_attribute(const String& name, const String& value) void HTMLBodyElement::parse_attribute(const String& name, const String& value)
{ {
if (name == "link") { if (name.equals_ignoring_case("link")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
document().set_link_color(color.value()); document().set_link_color(color.value());
} else if (name == "alink") { } else if (name.equals_ignoring_case("alink")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
document().set_active_link_color(color.value()); document().set_active_link_color(color.value());
} else if (name == "vlink") { } else if (name.equals_ignoring_case("vlink")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
document().set_visited_link_color(color.value()); document().set_visited_link_color(color.value());

2
Libraries/LibHTML/DOM/HTMLFontElement.cpp
View file

@ -14,7 +14,7 @@ HTMLFontElement::~HTMLFontElement()
void HTMLFontElement::apply_presentational_hints(StyleProperties& style) const void HTMLFontElement::apply_presentational_hints(StyleProperties& style) const
{ {
for_each_attribute([&](auto& name, auto& value) { for_each_attribute([&](auto& name, auto& value) {
if (name == "color") { if (name.equals_ignoring_case("color")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())
style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value())); style.set_property(CSS::PropertyID::Color, ColorStyleValue::create(color.value()));

2
Libraries/LibHTML/DOM/HTMLImageElement.cpp
View file

@ -16,7 +16,7 @@ HTMLImageElement::~HTMLImageElement()
void HTMLImageElement::parse_attribute(const String& name, const String& value) void HTMLImageElement::parse_attribute(const String& name, const String& value)
{ {
if (name == "src") if (name.equals_ignoring_case("src"))
load_image(value); load_image(value);
} }