RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibGUI: Remove redundant event handling in EmojiInputDialog

Browse source 
The Dialog class already handles closing on escape.
This commit is contained in:
thankyouverycool 2022-11-17 09:15:12 -05:00 • committed by Andreas Kling
parent a6581c2aac
commit 2028fbeae3
2 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibGUI/EmojiInputDialog.cpp
View file

@ -19,7 +19,6 @@
#include <LibGUI/Button.h> #include <LibGUI/Button.h>
#include <LibGUI/EmojiInputDialog.h> #include <LibGUI/EmojiInputDialog.h>
#include <LibGUI/EmojiInputDialogGML.h> #include <LibGUI/EmojiInputDialogGML.h>
#include <LibGUI/Event.h>
#include <LibGUI/Frame.h> #include <LibGUI/Frame.h>
#include <LibGUI/ScrollableContainerWidget.h> #include <LibGUI/ScrollableContainerWidget.h>
#include <LibGUI/TextBox.h> #include <LibGUI/TextBox.h>
@ -262,16 +261,4 @@ void EmojiInputDialog::select_first_displayed_emoji()
done(ExecResult::OK); done(ExecResult::OK);
} }
void EmojiInputDialog::event(Core::Event& event)
{
if (event.type() == Event::KeyDown) {
auto& key_event = static_cast<KeyEvent&>(event);
if (key_event.key() == Key_Escape) {
done(ExecResult::Cancel);
return;
}
}
Dialog::event(event);
}
} }

1
Userland/Libraries/LibGUI/EmojiInputDialog.h
View file

@ -26,7 +26,6 @@ public:
String const& selected_emoji_text() const { return m_selected_emoji_text; } String const& selected_emoji_text() const { return m_selected_emoji_text; }
private: private:
virtual void event(Core::Event&) override;
explicit EmojiInputDialog(Window* parent_window); explicit EmojiInputDialog(Window* parent_window);
Vector<Emoji> supported_emoji(); Vector<Emoji> supported_emoji();