RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:17:44 +00:00
Code Issues Activity Actions

Lagom: Build with -fsigned-char

Browse source 
When building on an arm host system, char defaults to unsigned,
leading to errors such as:

  serenity/AK/StringBuilder.cpp:198:20:
    error: comparison is always true due to limited range of data type
           [-Werror=type-limits]
    198 |             if (ch >= 0 && ch <= 0x1f)
        |

Building with -fsigned-char makes things work like on Intel, and
it's what we already do in Kernel/CMakeLists.txt for the same reasons.
This commit is contained in:
Nico Weber 2022-03-20 20:19:42 -04:00 • committed by Brian Gianforcaro
parent 917d06fa30
commit 20c6dabaff
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Meta/Lagom/CMakeLists.txt
View file

@ -57,6 +57,7 @@ endif()
include(wasm_spec_tests) include(wasm_spec_tests)
add_compile_options(-fsigned-char)
add_compile_options(-Wno-unknown-warning-option -Wno-literal-suffix -Wno-implicit-const-int-float-conversion) add_compile_options(-Wno-unknown-warning-option -Wno-literal-suffix -Wno-implicit-const-int-float-conversion)
add_compile_options(-O2) add_compile_options(-O2)
add_compile_options(-Wall -Wextra -Werror) add_compile_options(-Wall -Wextra -Werror)