RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

LibCore: Have CNetworkJob protect itself during the on_finish callback

Browse source 
Otherwise, the callback may trigger the destruction of the CNetworkJob
and make it difficult to continue execution correctly.
This commit is contained in:
Andreas Kling 2019-11-23 21:42:02 +01:00
parent 5d8324f133
commit 20c957ef61
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibCore/CNetworkJob.cpp
View file

@ -14,6 +14,10 @@ CNetworkJob::~CNetworkJob()
void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response) void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response)
{ {
// NOTE: We protect ourselves here, since the on_finish callback may otherwise
// trigger destruction of this job somehow.
NonnullRefPtr<CNetworkJob> protector(*this);
m_response = move(response); m_response = move(response);
#ifdef CNETWORKJOB_DEBUG #ifdef CNETWORKJOB_DEBUG
dbg() << *this << " job did_finish!"; dbg() << *this << " job did_finish!";
@ -25,6 +29,10 @@ void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response)
void CNetworkJob::did_fail(Error error) void CNetworkJob::did_fail(Error error)
{ {
// NOTE: We protect ourselves here, since the on_finish callback may otherwise
// trigger destruction of this job somehow.
NonnullRefPtr<CNetworkJob> protector(*this);
m_error = error; m_error = error;
#ifdef CNETWORKJOB_DEBUG #ifdef CNETWORKJOB_DEBUG
dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error)); dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error));