RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:17:35 +00:00
Code Issues Activity Actions

Kernel: Fetch range once for each iteration of find_regions_intersecting

Browse source 
pvs-studio flagged this as a potential optimization.
This commit is contained in:
Brian Gianforcaro 2021-09-15 23:50:46 -07:00 • committed by Andreas Kling
parent e8ec1e908d
commit 24207d3795
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Memory/AddressSpace.cpp
View file

@ -251,10 +251,11 @@ Vector<Region*> AddressSpace::find_regions_intersecting(VirtualRange const& rang
if (!found_region) if (!found_region)
return regions; return regions;
for (auto iter = m_regions.begin_from((*found_region)->vaddr().get()); !iter.is_end(); ++iter) { for (auto iter = m_regions.begin_from((*found_region)->vaddr().get()); !iter.is_end(); ++iter) {
if ((*iter)->range().base() < range.end() && (*iter)->range().end() > range.base()) { const auto& iter_range = (*iter)->range();
if (iter_range.base() < range.end() && iter_range.end() > range.base()) {
regions.append(*iter); regions.append(*iter);
total_size_collected += (*iter)->size() - (*iter)->range().intersect(range).size(); total_size_collected += (*iter)->size() - iter_range.intersect(range).size();
if (total_size_collected == range.size()) if (total_size_collected == range.size())
break; break;
} }