RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

LibWeb: Use JS::Handle for page pointer in LoadRequest

Browse source 
Since we can't visit page pointer from LoadRequest we need to use
JS::Handle to keep it alive.
This commit is contained in:
Aliaksandr Kalenik 2023-12-11 12:54:32 +01:00 • committed by Alexander Kalenik
parent 6ac43274b2
commit 286ea068fc
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Loader/LoadRequest.h
View file

@ -43,7 +43,7 @@ public:
void start_timer() { m_load_timer.start(); } void start_timer() { m_load_timer.start(); }
Duration load_time() const { return m_load_timer.elapsed_time(); } Duration load_time() const { return m_load_timer.elapsed_time(); }
JS::GCPtr<Page> page() { return m_page; } JS::GCPtr<Page> page() { return m_page.ptr(); }
void set_page(Page& page) { m_page = page; } void set_page(Page& page) { m_page = page; }
unsigned hash() const unsigned hash() const
@ -79,7 +79,7 @@ private:
HashMap<DeprecatedString, DeprecatedString, CaseInsensitiveStringTraits> m_headers; HashMap<DeprecatedString, DeprecatedString, CaseInsensitiveStringTraits> m_headers;
ByteBuffer m_body; ByteBuffer m_body;
Core::ElapsedTimer m_load_timer; Core::ElapsedTimer m_load_timer;
JS::GCPtr<Page> m_page; JS::Handle<Page> m_page;
bool m_main_resource { false }; bool m_main_resource { false };
}; };