RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:58:11 +00:00
Code Issues Activity Actions

LibJS: Use the match's global offset for 'index' in RegExp.exec()

Browse source 
This was not noticed before because all the previous matches were
single-line.
This commit is contained in:
Ali Mohammad Pur 2021-04-23 03:32:37 +04:30 • committed by Linus Groh
parent a697a2a37a
commit 2ef5b138ee
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -168,7 +168,7 @@ JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::exec)
// FIXME: Do code point index correction if the Unicode flag is set.
auto* array = Array::create(global_object);
array->indexed_properties().set_array_like_size(result.n_capture_groups + 1);
array->define_property(vm.names.index, Value((i32)match.column));
array->define_property(vm.names.index, Value((i32)match.global_offset));
array->define_property(vm.names.input, js_string(vm, str));
array->indexed_properties().put(array, 0, js_string(vm, match.view.to_string()));