RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:17:44 +00:00
Code Issues Activity Actions

LibCore: Change class_name to use StringView instead of char const*

Browse source 
This helps make the overall codebase consistent. `class_name()` in
`Kernel` is always `StringView`, but not elsewhere.

Additionally, this results in the `strlen` (which needs to be done
when printing or other operations) always being computed at
compile-time.
This commit is contained in:
Lenny Maiorani 2022-03-16 18:26:15 -06:00 • committed by Linus Groh
parent 66189169f9
commit 327e9a2187
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibCore/Object.h
View file

@ -14,6 +14,7 @@
#include <AK/NonnullRefPtrVector.h>
#include <AK/OwnPtr.h>
#include <AK/String.h>
#include <AK/StringView.h>
#include <AK/TypeCasts.h>
#include <AK/Weakable.h>
#include <LibCore/Forward.h>
@ -43,7 +44,7 @@ public:
ObjectClassRegistration(StringView class_name, Function<RefPtr<Object>()> factory, ObjectClassRegistration* parent_class = nullptr);
~ObjectClassRegistration() = default;
String class_name() const { return m_class_name; }
StringView class_name() const { return m_class_name; }
const ObjectClassRegistration* parent_class() const { return m_parent_class; }
RefPtr<Object> construct() const { return m_factory(); }
bool is_derived_from(const ObjectClassRegistration& base_class) const;
@ -66,7 +67,7 @@ enum class TimerShouldFireWhenNotVisible {
#define C_OBJECT(klass) \
public: \
virtual const char* class_name() const override { return #klass; } \
virtual StringView class_name() const override { return #klass; } \
template<typename Klass = klass, class... Args> \
static NonnullRefPtr<klass> construct(Args&&... args) \
{ \
@ -80,7 +81,7 @@ public:
#define C_OBJECT_ABSTRACT(klass) \
public: \
virtual const char* class_name() const override { return #klass; }
virtual StringView class_name() const override { return #klass; }
class Object
: public RefCounted<Object>
@ -95,7 +96,7 @@ class Object
public:
virtual ~Object();
virtual const char* class_name() const = 0;
virtual StringView class_name() const = 0;
const String& name() const { return m_name; }
void set_name(String name) { m_name = move(name); }