RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

Kernel: Put a note about the unconditional unblanking of bochs-display

Browse source 
This removes the FIXME note and explains why it's not so bad to do this.
This commit is contained in:
Liav A 2021-07-23 15:49:03 +03:00 • committed by Andreas Kling
parent 3c1797c42d
commit 3645861f31
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Graphics/Bochs/GraphicsAdapter.cpp
View file

@ -78,9 +78,9 @@ UNMAP_AFTER_INIT BochsGraphicsAdapter::BochsGraphicsAdapter(PCI::Address pci_add
if (id.vendor_id == 0x80ee && id.device_id == 0xbeef) if (id.vendor_id == 0x80ee && id.device_id == 0xbeef)
m_io_required = true; m_io_required = true;
// FIXME: Although this helps with setting the screen to work on some cases, // Note: According to Gerd Hoffmann - "The linux driver simply does
// we need to check we actually can access the VGA MMIO remapped ioports before // the unblank unconditionally. With bochs-display this is not needed but
// doing the unblanking. // it also has no bad side effect".
unblank(); unblank();
set_safe_resolution(); set_safe_resolution();
} }