RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

Meta: Add FIXME for not setting BUILD_SHARED_LIBS in Lagom build

Browse source 
This is really the business of the consuming project. We will need to
make changes to libjs-test262 and to oss-fuzz to address this properly.
This commit is contained in:
Andrew Kaster 2021-09-06 18:06:46 -06:00 • committed by Ali Mohammad Pur
parent a488041d54
commit 368d2ace55
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Meta/Lagom/CMakeLists.txt
View file

@ -38,9 +38,16 @@ if(ENABLE_ALL_THE_DEBUG_MACROS)
include(all_the_debug_macros) include(all_the_debug_macros)
endif() endif()
# FIXME: BUILD_SHARED_LIBS has a default of OFF, as it's intended to be set by the
# user when configuring the project. We should instead change libjs-test262
# and oss-fuzz to set this option on their end, and enable it by default in
# Meta/serenity.sh
# This is #9867. We can change the oss-fuzz escape hatch to be a FATAL_ERROR
# message instead when implementing it.
option(BUILD_SHARED_LIBS "Build shared libraries instead of static libraries" ON) option(BUILD_SHARED_LIBS "Build shared libraries instead of static libraries" ON)
if (ENABLE_OSS_FUZZ) if (ENABLE_OSS_FUZZ)
set(BUILD_SHARED_LIBS OFF) # Don't use shared libraries on oss-fuzz, for ease of integration with their infrastructure # Don't use shared libraries on oss-fuzz, for ease of integration with their infrastructure
set(BUILD_SHARED_LIBS OFF CACHE BOOL "Build shared libraries instead of static libraries" FORCE)
endif() endif()
find_package(Threads REQUIRED) find_package(Threads REQUIRED)