RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

LibWeb: Store MessageEvent::m_data in a JS::Handle

Browse source 
This protects it from GC.
This commit is contained in:
Luke Wilde 2022-07-11 14:24:14 +01:00 • committed by Linus Groh
parent 7b89c4e412
commit 38696dc626
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/MessageEvent.h
View file

@ -31,20 +31,20 @@ public:
virtual ~MessageEvent() override = default; virtual ~MessageEvent() override = default;
JS::Value data() const { return m_data; } JS::Value data() const { return m_data.value(); }
String const& origin() const { return m_origin; } String const& origin() const { return m_origin; }
String const& last_event_id() const { return m_last_event_id; } String const& last_event_id() const { return m_last_event_id; }
protected: protected:
MessageEvent(FlyString const& event_name, MessageEventInit const& event_init) MessageEvent(FlyString const& event_name, MessageEventInit const& event_init)
: DOM::Event(event_name, event_init) : DOM::Event(event_name, event_init)
, m_data(event_init.data) , m_data(JS::make_handle(event_init.data))
, m_origin(event_init.origin) , m_origin(event_init.origin)
, m_last_event_id(event_init.last_event_id) , m_last_event_id(event_init.last_event_id)
{ {
} }
JS::Value m_data; JS::Handle<JS::Value> m_data;
String m_origin; String m_origin;
String m_last_event_id; String m_last_event_id;
}; };