RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:17:35 +00:00
Code Issues Activity Actions

CrashDaemon: Remove BACKTRACE_DEBUG debugging code

Browse source 
This thing seems to work fine, no need to hang on to old debug code.
This commit is contained in:
Andreas Kling 2021-07-22 22:43:06 +02:00
parent cdae397e6a
commit 3f9e018d9a
3 changed files with 0 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
AK/Debug.h.in
View file

@ -14,10 +14,6 @@
#cmakedefine01 AFLACLOADER_DEBUG #cmakedefine01 AFLACLOADER_DEBUG
#endif #endif
#ifndef BACKTRACE_DEBUG
#cmakedefine01 BACKTRACE_DEBUG
#endif
#ifndef BMP_DEBUG #ifndef BMP_DEBUG
#cmakedefine01 BMP_DEBUG #cmakedefine01 BMP_DEBUG
#endif #endif

1
Meta/CMake/all_the_debug_macros.cmake
View file

@ -5,7 +5,6 @@ set(APIC_SMP_DEBUG ON)
set(ARP_DEBUG ON) set(ARP_DEBUG ON)
set(AWAVLOADER_DEBUG ON) set(AWAVLOADER_DEBUG ON)
set(AFLACLOADER_DEBUG ON) set(AFLACLOADER_DEBUG ON)
set(BACKTRACE_DEBUG ON)
set(BBFS_DEBUG ON) set(BBFS_DEBUG ON)
set(BMP_DEBUG ON) set(BMP_DEBUG ON)
set(BXVGA_DEBUG ON) set(BXVGA_DEBUG ON)

11
Userland/Services/CrashDaemon/main.cpp
View file

@ -75,18 +75,7 @@ static void print_backtrace(const String& coredump_path)
dbgln(); dbgln();
dbgln("--- Backtrace for thread #{} (TID {}) ---", thread_index, thread_info.tid); dbgln("--- Backtrace for thread #{} (TID {}) ---", thread_index, thread_info.tid);
for (auto& entry : backtrace.entries()) { for (auto& entry : backtrace.entries()) {
#ifndef BACKTRACE_DEBUG
dbgln("{}", entry.to_string(true)); dbgln("{}", entry.to_string(true));
#else
auto region = coredump->region_containing(entry.eip);
String name;
u32 base_addr { 0 };
if (region) {
name = region->region_name;
base_addr = region->region_start;
}
dbgln("{} ({} base: {:p}, offset: {:p})", entry.to_string(true), name, base_addr, entry.eip - base_addr);
#endif
} }
++thread_index; ++thread_index;
return IterationDecision::Continue; return IterationDecision::Continue;