RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

LibJS: Remove unused SetVariable::InitializationMode::InitializeOrSet

Browse source
This commit is contained in:
Andreas Kling 2023-09-26 09:36:28 +02:00
parent ba40526db2
commit 4c5b9fa6a2
2 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -599,11 +599,6 @@ ThrowCompletionOr<void> SetVariable::execute_impl(Bytecode::Interpreter& interpr
case InitializationMode::Set: case InitializationMode::Set:
TRY(reference.put_value(vm, interpreter.accumulator())); TRY(reference.put_value(vm, interpreter.accumulator()));
break; break;
case InitializationMode::InitializeOrSet:
VERIFY(reference.is_environment_reference());
VERIFY(reference.base_environment().is_declarative_environment());
TRY(static_cast<DeclarativeEnvironment&>(reference.base_environment()).initialize_or_set_mutable_binding(vm, name, interpreter.accumulator()));
break;
} }
return {}; return {};
} }
@ -1581,9 +1576,7 @@ DeprecatedString EnterObjectEnvironment::to_deprecated_string_impl(Executable co
DeprecatedString SetVariable::to_deprecated_string_impl(Bytecode::Executable const& executable) const DeprecatedString SetVariable::to_deprecated_string_impl(Bytecode::Executable const& executable) const
{ {
auto initialization_mode_name = m_initialization_mode == InitializationMode ::Initialize ? "Initialize" auto initialization_mode_name = m_initialization_mode == InitializationMode::Initialize ? "Initialize" : "Set";
: m_initialization_mode == InitializationMode::Set ? "Set"
: "InitializeOrSet";
auto mode_string = m_mode == EnvironmentMode::Lexical ? "Lexical" : "Variable"; auto mode_string = m_mode == EnvironmentMode::Lexical ? "Lexical" : "Variable";
return DeprecatedString::formatted("SetVariable env:{} init:{} {} ({})", mode_string, initialization_mode_name, m_identifier, executable.identifier_table->get(m_identifier)); return DeprecatedString::formatted("SetVariable env:{} init:{} {} ({})", mode_string, initialization_mode_name, m_identifier, executable.identifier_table->get(m_identifier));
} }

1
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -408,7 +408,6 @@ public:
enum class InitializationMode { enum class InitializationMode {
Initialize, Initialize,
Set, Set,
InitializeOrSet,
}; };
explicit SetVariable(IdentifierTableIndex identifier, InitializationMode initialization_mode = InitializationMode::Set, EnvironmentMode mode = EnvironmentMode::Lexical) explicit SetVariable(IdentifierTableIndex identifier, InitializationMode initialization_mode = InitializationMode::Set, EnvironmentMode mode = EnvironmentMode::Lexical)
: Instruction(Type::SetVariable, sizeof(*this)) : Instruction(Type::SetVariable, sizeof(*this))