RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

LibWeb: Fix the update of the favicon during navigation

Browse source 
The check on the currently active document for an existing favicon has
been removed. It caused an issue during navigation because the active
document will only be updated after the load and the favicon check has
been executed against the old document.
This commit is contained in:
Emil Militzer 2023-04-24 10:39:08 +02:00 • committed by Tim Flynn
parent eba72fa3a7
commit 50af15e6b8
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -267,10 +267,6 @@ bool FrameLoader::load(LoadRequest& request, Type type)
if (type == Type::IFrame)
return true;
auto* document = browsing_context().active_document();
if (document && document->has_active_favicon())
return true;
if (url.scheme() == "http" || url.scheme() == "https") {
AK::URL favicon_url;
favicon_url.set_scheme(url.scheme());