RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

Kernel: Remove unnecessary SmapDisablers in FileDescription

Browse source 
Since we're using UserOrKernelBuffers, SMAP will be automatically
disabled when we actually access the buffer later on. There's no need
to disable it wholesale across the entire read/write operations.
This commit is contained in:
Andreas Kling 2020-11-23 20:50:22 +01:00
parent 1dc480e097
commit 541579bc04
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/FileDescription.cpp
View file

@ -123,7 +123,6 @@ KResultOr<size_t> FileDescription::read(UserOrKernelBuffer& buffer, size_t count
new_offset += count;
if (new_offset.has_overflow())
return -EOVERFLOW;
SmapDisabler disabler;
auto nread_or_error = m_file->read(*this, offset(), buffer, count);
if (!nread_or_error.is_error() && m_file->is_seekable())
m_current_offset += nread_or_error.value();
@ -137,7 +136,6 @@ KResultOr<size_t> FileDescription::write(const UserOrKernelBuffer& data, size_t
new_offset += size;
if (new_offset.has_overflow())
return -EOVERFLOW;
SmapDisabler disabler;
auto nwritten_or_error = m_file->write(*this, offset(), data, size);
if (!nwritten_or_error.is_error() && m_file->is_seekable())
m_current_offset += nwritten_or_error.value();