RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:14:58 +00:00
Code Issues Activity Actions

Browser+Ladybird+LibWebView: Consolidate title handling in LibWebView

Browse source 
Namely, let's have empty titles behave the same in both Browser and
Ladybird (display the URL).
This commit is contained in:
Timothy Flynn 2023-06-07 16:37:30 -04:00 • committed by Andreas Kling
parent f2a28e83de
commit 5a3825b561
3 changed files with 13 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -95,7 +95,12 @@ void WebContentClient::did_change_title(DeprecatedString const& title)
{
dbgln_if(SPAM_DEBUG, "handle: WebContentClient::DidChangeTitle! title={}", title);
if (m_view.on_title_change)
if (!m_view.on_title_change)
return;
if (title.is_empty())
m_view.on_title_change(m_view.url().to_deprecated_string());
else
m_view.on_title_change(title);
}