RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:37:46 +00:00
Code Issues Activity Actions

ClipboardHistory: Use i32 config change listener

Browse source 
Fixes a FIXME.
This commit is contained in:
kleines Filmröllchen 2023-06-26 21:07:58 +02:00 • committed by Sam Atkins
parent 33829f05fe
commit 5c8405c455
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp
View file

@ -155,17 +155,12 @@ void ClipboardHistoryModel::clear()
invalidate_model_and_file(true).release_value_but_fixme_should_propagate_errors(); invalidate_model_and_file(true).release_value_but_fixme_should_propagate_errors();
} }
void ClipboardHistoryModel::config_string_did_change(StringView domain, StringView group, StringView key, StringView value_string) void ClipboardHistoryModel::config_i32_did_change(StringView domain, StringView group, StringView key, i32 value)
{ {
if (domain != "ClipboardHistory" || group != "ClipboardHistory") if (domain != "ClipboardHistory" || group != "ClipboardHistory")
return; return;
// FIXME: Once we can get notified for `i32` changes, we can use that instead of this hack.
if (key == "NumHistoryItems") { if (key == "NumHistoryItems") {
auto value_or_error = value_string.to_int();
if (!value_or_error.has_value())
return;
auto value = value_or_error.value();
if (value < (int)m_history_items.size()) { if (value < (int)m_history_items.size()) {
m_history_items.remove(value, m_history_items.size() - value); m_history_items.remove(value, m_history_items.size() - value);
invalidate_model_and_file(false).release_value_but_fixme_should_propagate_errors(); invalidate_model_and_file(false).release_value_but_fixme_should_propagate_errors();

2
Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h
View file

@ -53,7 +53,7 @@ public:
virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override; virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override;
// ^Config::Listener // ^Config::Listener
virtual void config_string_did_change(StringView domain, StringView group, StringView key, StringView value) override; virtual void config_i32_did_change(StringView domain, StringView group, StringView key, i32 value) override;
private: private:
ClipboardHistoryModel(); ClipboardHistoryModel();